Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to rs-0.46 #309

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrading to rs-0.46 #309

wants to merge 5 commits into from

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented Feb 14, 2025

Upgrading:

  • Pola.rs -> 0.46.0
  • toolchain -> nightly-2025-01-05
  • Yarn -> 4.6.0

Skipping 2 broken serialization tests for now.

@Bidek56
Copy link
Collaborator Author

Bidek56 commented Feb 14, 2025

Broken serialization tests are caused by this code.

#[napi]
impl JsDataFrame {
    #[napi(catch_unwind)]
    pub fn to_js(&self, env: Env) -> napi::Result<napi::JsUnknown> {
       --> env.to_js_value(&self.df)
    }
....

And likely caused by this PR

@Bidek56 Bidek56 marked this pull request as ready for review February 21, 2025 15:47
@Bidek56 Bidek56 self-assigned this Feb 23, 2025
@Bidek56 Bidek56 added the enhancement New feature or request label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant