Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a maximum size in bytes for an input when creating a GGPOSession? #54

Closed
Eoin-ONeill-Yokai opened this issue Jan 30, 2020 · 3 comments

Comments

@Eoin-ONeill-Yokai
Copy link

So I've been testing GGPO on Linux, which I know isn't a supported plaform yet, and I've run into a small problem. I've noticed that GGPO crashes when the input size is anything larger than 18 bytes. Is 18 bytes the maximum input size that GGPO supports? Or is this simply a bug? I'm using a branch based on PR #52 .

@Shugyousha
Copy link
Contributor

It looks like 18 bytes is the preconfigured max: https://github.com/pond3r/ggpo/blob/master/src/lib/ggpo/game_input.h#L26

I assume that can be adjusted freely (as long as you make sure to heed this comment: https://github.com/pond3r/ggpo/blob/master/src/lib/ggpo/game_input.h#L14).

@pond3r
Copy link
Owner

pond3r commented Feb 9, 2020

Yes, you should be fine, though I've never tested it with inputs that large.

@Eoin-ONeill-Yokai
Copy link
Author

Ok that's good to know.

I'm going to go ahead and close this issue then since it seems to be addressed. Thanks for taking the time to respond!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants