Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant check in Response #16

Merged
merged 1 commit into from
Nov 25, 2024
Merged

remove redundant check in Response #16

merged 1 commit into from
Nov 25, 2024

Conversation

garak
Copy link
Contributor

@garak garak commented Nov 23, 2024

Fix #15

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Nov 23, 2024

PR Summary

  • Removed Unused Elements
    The unnecessary import for ResponseHeaderBag has been eliminated to ensure a cleaner and more efficient codebase.

  • Deleted contentDispositionDirectives Array and Validation Check
    The contentDispositionDirectives array and a related validation check for contentDisposition were removed. This simplifies the constructor, making it easier to understand and maintain.

@endelwar endelwar merged commit 36b16cf into pontedilana:develop Nov 25, 2024
9 checks passed
@garak garak deleted the fix-response branch November 25, 2024 10:38
@endelwar
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant check in WeasyPrintResponse
2 participants
@garak @endelwar