Support loading multiple file URLs (CLI/file managers) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuamegnauth54
force-pushed
the
improve-url-command-line
branch
from
0d71ce0 to
2f2d70e
Compare
Prior to this commit, projects/playlists were limited to folders even if file URLs were passed as arguments. With this commit both files and folders are added to projects from the command line. This doesn't affect opening a file from the GUI yet, but this patch implements the required plumbing for that as well.
joshuamegnauth54
force-pushed
the
improve-url-command-line
branch
from
2f2d70e to
698a69b
Compare
joshuamegnauth54
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44
This patch adds support for starting COSMIC Player with multiple, mixed URLs. As in #75, this is primarily useful for file managers which may start the program with multiple files and folders.
I added pico-args as a dependency to aid argument parsing.
pico-argsdoesn't have any dependencies and only adds 1KB of binary bloat as opposed toclapwhich adds almost a megabyte of bloat. I used a dependency instead of simply looping through the arguments because I assume that command line args will be added in the future, so I might as well implement this the right way instead of adding maintenance burden.I did not update the
Open Filebutton to take advantage of the new functionality. However, it should be a lot easier now to support that in a future patch.