Add omniauth tests and fix identifier_scheme bug

Here we have a first pass of working integration tests for omniauth SSO.

The tests still need to check for the messages we are setting as
notifications.

We can think about splitting the tests into integration and controller
tests.

Author: lagoan

app/models/identifier_scheme.rb

@@ -62,7 +62,7 @@ class IdentifierScheme < ApplicationRecord
   #    { "ror": "12345" }
   # so we cannot allow spaces or non alpha characters!
   def name=(value)
-    super(value&.downcase&.gsub(/[^a-z]/, ''))
+    super(value&.downcase&.gsub(/[^a-z|_]/, ''))
   end
 
   # ===========================

app/models/user.rb

@@ -189,7 +189,7 @@ def self.create_from_provider_data(provider_data)
 
     return user if user
 
-    user = User.new(
+    User.create!(
       firstname: provider_data.info.first_name,
       surname: provider_data.info.last_name,
       email: provider_data.info.email,
@@ -198,8 +198,6 @@ def self.create_from_provider_data(provider_data)
       accept_terms: true,
       password: Devise.friendly_token[0, 20]
     )
-
-    user.save!
   end
 
   def self.to_csv(users)
@@ -239,7 +237,6 @@ def locale
   # Returns String
   # rubocop:disable Style/OptionalBooleanParameter
   def name(use_email = true)
-    # byebug
     if (firstname.blank? && surname.blank?) || use_email
       email
     else

db/seeds/test.rb

@@ -68,6 +68,12 @@
     logo_url: 'http://newsite.shibboleth.net/wp-content/uploads/2017/01/Shibboleth-logo_2000x1200-1.png',
     identifier_prefix: "https://example.com"
   },
+  {
+    name: "openid_connect",
+    description: "CILogon",
+    active: true,
+    identifier_prefix: "https://www.cilogon.org/",
+  },
 ]
 identifier_schemes.each { |is| IdentifierScheme.create!(is) }
 
@@ -249,7 +255,13 @@
    abbreviation: 'UOS',
    org_type: 1, links: {"org":[]},
    language: default_language, region: region,
-   is_other: false, managed: true}
+   is_other: false, managed: true},
+   {name: 'Other organisation',
+   abbreviation: 'OO',
+   org_type: 1, links: {"org":[]},
+   language: default_language, region: region,
+   is_other: true, managed: true}
+
 ]
 orgs.each { |o| Org.create!(o) }
 

spec/integration/openid_connect_sso_test.rb

@@ -0,0 +1,80 @@
+require 'rails_helper'
+
+RSpec.describe 'Openid_connection SSO', type: :feature do
+  context 'with correct credentials' do
+    before do
+      create(:org, managed: false, is_other: true)
+      @org = create(:org, managed: true)
+      @identifier_scheme = create(:identifier_scheme,
+                                  name: 'openid_connect',
+                                  description: 'CILogon',
+                                  active: true,
+                                  identifier_prefix: 'https://www.cilogon.org/')
+      # OmniAuth.config.add_mock(openid_connect: {
+      #                            provider: 'openid_connect',
+      #                            uid: '12345',
+      #                            info:
+      #     { email: 'user@organization.ca',
+      #       first_name: 'John',
+      #       last_name: 'Doe' }
+      #                          })
+
+      #                       OmniAuth.config.add_mock(openid_connect: {
+      #                       'provider' => 'openid_connect',
+      #                       'uid' => '12345',
+      #                       'info' =>
+      # { 'email' => 'user@organization.ca',
+      #   'first_name' => 'John',
+      #   'last_name' => 'Doe' }
+      #                     })
+
+      # OmniAuth.config.add_mock(:openid_connect, {
+      #                            provider: 'openid_connect',
+      #                            uid: '12345',
+      #                            info: {
+      #                              email: 'user@organization.ca',
+      #                              first_name: 'John',
+      #                              last_name: 'Doe'
+      #                            }
+      #                          })
+      #       OmniAuth.config.mock_auth[:openid_connect] = OmniAuth::AuthHash.new({
+      #                                                                       provider: 'openid_connect',
+      #                                                                       uid: '12345',
+      #                                                                       info:
+      # { email: 'user@organization.ca',
+      #   first_name: 'John',
+      #   last_name: 'Doe' }
+      Rails.application.env_config['devise.mapping'] = Devise.mappings[:user]
+      Rails.application.env_config['omniauth.auth'] = OmniAuth.config.mock_auth[:openid_connect]
+    end
+
+    # it 'links external credentials with existing account' do
+    # end
+
+    it 'creates account from external credentials' do
+      visit root_path
+      click_link 'Sign in with CILogon'
+
+      identifier = Identifier.last
+      expect(identifier.value).to eql('https://www.cilogon.org/12345')
+      identifiable = identifier.identifiable
+      expect(identifiable.email).to eql('user@organization.ca')
+      expect(identifiable.firstname).to eql('John')
+      expect(identifiable.surname).to eql('Doe')
+
+      # XXX Check notice message
+    end
+
+    it 'links account from external credentails' do
+      # Create existing user
+      create(:user, :org_admin, org: @org, email: 'user@organization.ca')
+      visit root_path
+      click_link 'Sign in with CILogon'
+      identifier = Identifier.last
+      expect(identifier.value).to eql('https://www.cilogon.org/12345')
+      identifiable = identifier.identifiable
+      # We will find the new user with the email specified above
+      expect(identifiable.email).to eql('user@organization.ca')
+    end
+  end
+end

spec/spec_helper.rb

@@ -2,6 +2,7 @@
 
 require 'capybara/rspec'
 require 'mocha'
+require 'omniauth'
 
 $LOAD_PATH.unshift(File.expand_path(__dir__))
 
@@ -119,3 +120,17 @@
     # Capybara::Webmock.stop if example.metadata[:type] == :feature
   end
 end
+
+OmniAuth.config.test_mode = true
+
+OmniAuth.config.mock_auth[:openid_connect] = OmniAuth::AuthHash.new(
+  {
+    provider: 'openid_connect',
+    uid: '12345',
+    info: {
+      email: 'user@organization.ca',
+      first_name: 'John',
+      last_name: 'Doe'
+    }
+  }
+)