Skip to content

Commit d5c9118

Browse files
authored
rerun build when saving on build tab (#4500)
1 parent 3e03919 commit d5c9118

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

dashboard/src/main/home/app-dashboard/app-view/AppDataContainer.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,9 @@ const AppDataContainer: React.FC<AppDataContainerProps> = ({ tabParam }) => {
197197
try {
198198
const { variables, secrets, validatedAppProto } = await validateApp(data);
199199

200+
const porterUserOnBuildTab =
201+
currentTab === "build-settings" && user?.isPorterUser;
202+
200203
const needsRebuild =
201204
buildIsDirty ||
202205
latestRevision.status === "BUILD_FAILED" ||
@@ -240,7 +243,10 @@ const AppDataContainer: React.FC<AppDataContainerProps> = ({ tabParam }) => {
240243
);
241244
}
242245

243-
if (latestSource.type === "github" && needsRebuild) {
246+
if (
247+
latestSource.type === "github" &&
248+
(needsRebuild || porterUserOnBuildTab)
249+
) {
244250
// add a new revision with updated build settings only if they have changed
245251
if (validatedAppProto.build && buildIsDirty) {
246252
await api.updateBuildSettings(

0 commit comments

Comments
 (0)