Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janno for 2024_Sasso_PNAS #43

Merged

Conversation

Kavlahkaff
Copy link
Contributor

@Kavlahkaff Kavlahkaff commented Jan 9, 2025

Filled janno for 2024_Sasso_PNAS

  • Some dates are still missing

@Kavlahkaff Kavlahkaff requested a review from TCLamnidis January 9, 2025 13:36
@Kavlahkaff
Copy link
Contributor Author

@TCLamnidis I am unsure about how to fill some of the dates. In the Appendix on page 1-2 they give date ranges for the three sites. They seem to have taken these from other publications, but I wasn't able to find where exactly they've taken them from. Should I just put the date as contextual with the given range for these indivuduals, or do you have a hint where I can find this information?

@TCLamnidis
Copy link
Member

Just had a look at the table you linked. Those dates should go in as contextual. C14 should only be used for direct C14 dates (i.e. the individual in question was directly sampled for C14 dating). In this case, those dates are either contextual archaeological dates, or compound from various dating methods on the sites. Both of these cases would fall under contextual within the Poseidon schema.

Copy link
Member

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kavlahkaff!

One value was quoted. Please check that my suggested fix does not shift any columns around (it's hard to tell on GitHub sometimes).

Regarding the missing dating information, I think that can be recorded as contextual dates.

Please made the changes and I can then merge :)

@TCLamnidis TCLamnidis assigned Kavlahkaff and unassigned TCLamnidis Feb 5, 2025
@TCLamnidis
Copy link
Member

@Kavlahkaff any updates on this?

@Kavlahkaff Kavlahkaff marked this pull request as ready for review February 18, 2025 11:17
@Kavlahkaff
Copy link
Contributor Author

@TCLamnidis I have added the contextual dates and removed the quotation marks.

@TCLamnidis
Copy link
Member

Thank you! Looks good!

@TCLamnidis TCLamnidis merged commit 3ec7534 into poseidon-framework:2024_Sasso_PNAS Feb 18, 2025
1 check failed
TCLamnidis added a commit that referenced this pull request Feb 24, 2025
* Add 2024_Sasso_PNAS

* Add BibTex info and Publication column. Add package description.

* janno for 2024_Sasso_PNAS (#43)

* filled janno for 2024_Sasso_PNAS

* added group names

* added contextual dates, fixed quotation marks

* Add calibrated dates for C14 samples. Add extra publication for samples with C14 taken from other paper.

---------

Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>

* Add janno info collected by @Kavlahkaff. Mirror info to fam file.

* Add secondary citation to BibFile

* Remove empty columns from jannoFile

* Fix janno header: SNPs Ps -> SNPs. Update Date info on WPK004_MNT and SintTruiden

---------

Co-authored-by: Kavlahkaff <73996300+Kavlahkaff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants