Add agree to privacy policy to download page #47
Conversation
Adds checkbox agreeing to privacy policy before showing the downloads
✅ Deploy Preview for positron-posit-co ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thank you so much for working on this! 🙌
What do you think our options would be if we invested just a little bit more in the UX experience? To me, this version feels quite jumpy ("SURPRISE, HERE IS THE TABLE!!!") and a bit unusual for typical website UX.
- Instead of totally hidden, could the table be grayed out or obscured/unclickable?
- What about a popup that must be accepted?
- Other ideas?
I'm wondering if we can get an experience that may be less surprising to typical website users with a bit more time investment.
These ideas are helpful! I wasn't sure what the experience should be like. I did have something to blur the table. Hiding it was easiest since the blur still requires actual disabling of the links. I'll add some link disabling and that will open up options for how the content is revealed. |
|
@juliasilge I've added a change with a couple of things to try out once the preview deployment has completed.
The dialog can be customized more for style and behaviour. It's possible to change the dialog buttons to accept/decline the license and privacy and only allow the download if accept is selected. I think with some more changes the dialog is more obvious why the download didn't start and can present the option of accepting or declining. |
|
This is looking good! I think not having the table appear/disappear (but instead be disabled) is much better.
Yes, I agree that the dialog is more obvious and a few more changes here would be great:
|
download.qmd
Outdated
| </div> | ||
|
|
||
| <dialog id="accept-dialog"> | ||
| <p>Agree to the privacy policy to download Positron.</p> |
There was a problem hiding this comment.
Minor, but can we sync on this wording?
There was a problem hiding this comment.
Yes, I've updated the dialog text and used the text that was for the checkbox.
Must accept modal to download
| </div> | ||
| <div class="modal-body"> | ||
| <p> | ||
| I agree to the <a href="licensing.html" target="_">Positron license agreement</a> and |
There was a problem hiding this comment.
I tried using href="licensing" here but the preview can't navigate to it like with a live site. I've set the target to licensing.html so that it works in the preview.
|
I've changed to the modal dialog using Bootstrap components and fixed up the dialog text. The links have been scrubbed of the download URLs and set as data attributes. The agreement on the dialog will use that to navigate to the download. Declining the dialog close it.
|
|
It's a minor difference with it being a dialog now instead of a checkbox but I think the desired behaviour is the same. The user is agreeing by clicking on |
|
I am not seeing a dialog at https://deploy-preview-47--positron-posit-co.netlify.app/download.html now; do you know what might have happened? |
_download_modal.html
Outdated
| <div class="modal-header"> | ||
| <h5>License Agreement and Privacy Policy</h5> | ||
| <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> | ||
| </div> |
There was a problem hiding this comment.
This seems a bit redundant with the modal content. What do we think about removing the header?
There was a problem hiding this comment.
I thought it looked a bit empty without the header text. I can take it out and try out some other styling to tighten it up.
There was a problem hiding this comment.
Here's what it looks like without the modal header. I think this is much cleaner.
There was a problem hiding this comment.
Yes, I like this a lot! 🎉
I'm not seeing this dialog at https://deploy-preview-47--positron-posit-co.netlify.app/download.html, including in incognito mode. Do you know what might be happening there?
There was a problem hiding this comment.
I got the details after a screenshare with Pete. The modal doesn't appear until clicking on a link to download. It was the first thought for me when imagining how it it work. It's not too much to change it to show on page load.
Another option is reverting to the checkbox with a dialog showing when attempting to download without agreeing. So the user clicks the link and if the checkbox isn't checked, a dialog appears preventing the download with a reason.
Set border to 0
|
Here's an alternate option with a fade to show that the content is available. The links are not clickable or focusable and the colour is greyed out until the checkbox is ticked. Screen.Recording.2025-02-20.at.4.47.43.PM.mov |
Address https://github.com/posit-dev/positron-builds/issues/224
Adds checkbox agreeing to privacy policy before showing the downloads. The checkbox must be selected before the download links appear.
The checkbox has a click handler that toggles a
hiddenclass attribute that hides the element.Screen.Recording.2025-02-18.at.5.08.25.PM.mov