Skip to content

Commit fe82551

Browse files
Brian SwisherBrian Swisher
Brian Swisher
authored and
Brian Swisher
committed
[c] adjust workflow commands for NodeJS 18
1 parent 2bf6d2d commit fe82551

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@ jobs:
1414
- uses: actions/checkout@v1
1515
- uses: actions/setup-node@master
1616
with:
17-
node-version: '14'
17+
node-version: '18'
1818
- name: lint all markdownfiles
1919
env:
2020
PM_TECH: ${{secrets.PM_TECH}}
2121
run: |
2222
npm config set //registry.npmjs.org/:_authToken=${{secrets.NPM_TOKEN}}
23-
npm run bff
2423
npm run npm
2524
node_modules/.bin/markdownlint ./ --ignore node_modules
2625
- name: check for image url
@@ -35,7 +34,6 @@ jobs:
3534
PM_TECH: ${{secrets.PM_TECH}}
3635
run: |
3736
npm config set //registry.npmjs.org/:_authToken=${{secrets.NPM_TOKEN}}
38-
npm run bff
3937
npm run npm
4038
npm run clean
4139
npm run test:update

.github/workflows/deploy-beta.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup Node
2222
uses: actions/setup-node@master
2323
with:
24-
node-version: '14'
24+
node-version: '18'
2525

2626
- name: Configure AWS Credentials
2727
uses: aws-actions/configure-aws-credentials@v1
@@ -41,7 +41,6 @@ jobs:
4141
DOMAIN_NAME: ${{secrets.BETA_DOMAIN_NAME}}
4242
run: |
4343
npm config set //registry.npmjs.org/:_authToken=${{secrets.NPM_TOKEN}}
44-
npm run bff
4544
npm run npm
4645
npm run clean
4746
npm run build:dev

.github/workflows/deploy-prod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup Node
2222
uses: actions/setup-node@master
2323
with:
24-
node-version: '14'
24+
node-version: '18'
2525

2626
- name: Configure AWS Credentials
2727
uses: aws-actions/configure-aws-credentials@v1

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"am": "npm link 'aether-marketing; npm run dev",
8585
"bff": "NODE_ENV=development node bff.js",
8686
"build": "npm run bff && GATSBY_ACTIVE_ENV=production gatsby build --prefix-paths",
87-
"build:dev": "npm run build",
87+
"build:dev": "npm run bff && npm run build",
8888
"npm": "npm install --legacy-peer-deps --loglevel=error",
8989
"nvmrc": "echo $(node -p -e 'require(\"./package\").engines.node.split(\">=\").join(\"\")') > .nvmrc",
9090
"build:prod": "NODE_ENV=production node bff.js && GATSBY_ACTIVE_ENV=production gatsby build --prefix-paths",

0 commit comments

Comments
 (0)