[poa-2928] Add repro mode flag to kube run (#85)

Changes:
* Added a `--repro-mode` persistent flag to the `kube run` command
* Remove `INSIGHTS_REPRO_MODE_ENABLED` env var
* Added `RemovePodFromMap` to `isEndState()`
* Remove debug level check in dump map function; this table will be
logged every 5 minutes, which should not be noisy.
* Improvement over this would be to print only when there is a change in
the map since last time.

Author: mudit-postman

cmd/internal/kube/daemonset/constants.go

@@ -11,7 +11,6 @@ const (
 	POSTMAN_INSIGHTS_ENV                = "POSTMAN_ENV" // This is same as root POSTMAN_ENV
 	POSTMAN_INSIGHTS_VERIFICATION_TOKEN = "POSTMAN_INSIGHTS_VERIFICATION_TOKEN"
 	POSTMAN_INSIGHTS_CLUSTER_NAME       = "POSTMAN_INSIGHTS_CLUSTER_NAME"
-	POSTMAN_INSIGHTS_REPRO_MODE_ENABLED = "POSTMAN_INSIGHTS_REPRO_MODE_ENABLED"
 
 	// Workers intervals
 	DefaultTelemetryInterval      = 5 * time.Minute

cmd/internal/kube/daemonset/daemonset.go

@@ -26,6 +26,10 @@ const (
 	agentImage        = "public.ecr.aws/postman/postman-insights-agent:latest"
 )
 
+type DaemonsetArgs struct {
+	ReproMode bool
+}
+
 type Daemonset struct {
 	ClusterName              string
 	InsightsEnvironment      string
@@ -46,7 +50,7 @@ type Daemonset struct {
 	TelemetryInterval      time.Duration
 }
 
-func StartDaemonset() error {
+func StartDaemonset(args DaemonsetArgs) error {
 	// Check if the agent is running in a linux environment
 	if runtime.GOOS != "linux" {
 		return errors.New("This command is only supported on linux images")
@@ -95,13 +99,10 @@ func StartDaemonset() error {
 		return errors.Wrap(err, "failed to create CRI client")
 	}
 
-	insightsReproModeEnabled := os.Getenv(POSTMAN_INSIGHTS_REPRO_MODE_ENABLED) == "true"
-	insightsEnvironment := os.Getenv(POSTMAN_INSIGHTS_ENV)
-
 	daemonsetRun := &Daemonset{
 		ClusterName:              clusterName,
-		InsightsEnvironment:      insightsEnvironment,
-		InsightsReproModeEnabled: insightsReproModeEnabled,
+		InsightsEnvironment:      os.Getenv(POSTMAN_INSIGHTS_ENV),
+		InsightsReproModeEnabled: args.ReproMode,
 		KubeClient:               kubeClient,
 		CRIClient:                criClient,
 		FrontClient:              frontClient,

cmd/internal/kube/daemonset/pod_args.go

@@ -96,5 +96,10 @@ func (p *PodArgs) changePodTrafficMonitorState(
 
 // isEndState checks if the pod traffic monitor state is in the final state.
 func (p *PodArgs) isEndState() bool {
-	return p.PodTrafficMonitorState == TrafficMonitoringEnded || p.PodTrafficMonitorState == TrafficMonitoringFailed
+	switch p.PodTrafficMonitorState {
+	case TrafficMonitoringEnded, TrafficMonitoringFailed, RemovePodFromMap:
+		return true
+	default:
+		return false
+	}
 }

cmd/internal/kube/daemonset/telemetry.go

@@ -5,7 +5,6 @@ import (
 	"time"
 
 	"github.com/postmanlabs/postman-insights-agent/printer"
-	"github.com/spf13/viper"
 	"k8s.io/apimachinery/pkg/types"
 )
 
@@ -25,12 +24,9 @@ func (d *Daemonset) sendTelemetry() {
 	}
 }
 
-// dumpPodsApiDumpProcessState logs the current state of active pods if the debug mode is enabled.
+// dumpPodsApiDumpProcessState logs the current state of active pods.
 // It prints a formatted table with the pod name, project ID, and current state for each pod.
 func (d *Daemonset) dumpPodsApiDumpProcessState() {
-	if !viper.GetBool("debug") {
-		return
-	}
 	logf := printer.Debugf
 
 	const hrBr = "================================================================================" +

cmd/internal/kube/run.go

@@ -6,9 +6,12 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func StartDaemonsetAndHibernateOnError(_ *cobra.Command, args []string) error {
-	err := daemonset.StartDaemonset()
+var (
+	reproMode bool
+)
 
+func StartDaemonsetAndHibernateOnError(_ *cobra.Command, args []string) error {
+	err := daemonset.StartDaemonset(daemonset.DaemonsetArgs{ReproMode: reproMode})
 	if err == nil {
 		return nil
 	}
@@ -28,6 +31,14 @@ var runCmd = &cobra.Command{
 }
 
 func init() {
+	runCmd.PersistentFlags().BoolVar(
+		&reproMode,
+		"repro-mode",
+		false,
+		"Enable Repro Mode to capture request and response payloads for debugging.",
+	)
+	_ = runCmd.PersistentFlags().MarkHidden("repro-mode")
+
 	Cmd.AddCommand(runCmd)
 
 	// Mark the inherited `project` flag as hidden