Skip to content

Commit cb1d224

Browse files
[POA-2570] Remove quotes around EXTRA_APIDUMP_ARGS (#59)
`ExecStart={{.AgentInstallPath}} apidump --project "${PROJECT_ID}" --interfaces "${INTERFACES}" --filter "${FILTER}" {{.ExtraApidumpArgs}} "${EXTRA_APIDUMP_ARGS}"` In the above command, if `EXTRA_APIDUMP_ARGS` env var is empty, then apidump will interpret it as quotes (`""`), which will error out with message `[ERROR] accepts 0 arg(s), received 1`. Remove the quotes surrounding the environment command.
1 parent 78490da commit cb1d224

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmd/internal/ec2/postman-insights-agent.service.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ After=network-online.target NetworkManager.service systemd-resolved.service
66
[Service]
77
EnvironmentFile=/etc/default/postman-insights-agent
88
# DO NOT CHANGE
9-
# "${FOO}" uses the arguement as is, while "$FOO" splits the string on white space
9+
# "${FOO}" uses the argument as is, while "$FOO" splits the string on white space
1010
# Reference: https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines
11-
ExecStart={{.AgentInstallPath}} apidump --project "${PROJECT_ID}" --interfaces "${INTERFACES}" --filter "${FILTER}" {{.ExtraApidumpArgs}} "${EXTRA_APIDUMP_ARGS}"
11+
ExecStart={{.AgentInstallPath}} apidump --project "${PROJECT_ID}" --interfaces "${INTERFACES}" --filter "${FILTER}" {{.ExtraApidumpArgs}} ${EXTRA_APIDUMP_ARGS}
1212

1313
[Install]
1414
WantedBy=multi-user.target

0 commit comments

Comments
 (0)