Remove get services calls from active commands (#114)

In this PR, we have removed the usage of the `GetServices()` function in
the front client because this endpoint uses a deprecated endpoint, which
will be removed soon and will not work with Postman authentication.

Changes:
* Updated the specs command to take serviceID input as a `--project`
flag.
* Also updated `GetTraceURIByTags` function to take serviceID as a
parameter instead of looking for it from BE.
* I have to not removed the `GetServices()` function yet since it is
still being used by some deprecated commands, like nginx which will be
removed as a part of agent code clean-up.

Author: mudit-postman

cmd/internal/apidump/apidump.go

@@ -157,6 +157,7 @@ func apidumpRunInternal(cmd *cobra.Command, _ []string) error {
 		destURI, err := util.GetTraceURIByTags(rest.Domain,
 			telemetry.GetClientID(),
 			outFlag.AkitaURI.ServiceName,
+			serviceID,
 			traceTags,
 			"append-by-tag",
 		)

cmd/internal/legacy/specs.go

@@ -47,7 +47,7 @@ You may specify the API spec by version name (e.g. "latest") or an ID (e.g.
 
 // GetSpec flags
 var (
-	getSpecServiceFlag             string
+	getSpecProjectIDFlag           string
 	getSpecOutputFlag              string
 	getSpecTimeoutFlag             time.Duration
 	getSpecWaitFlag                bool
@@ -58,10 +58,10 @@ func init() {
 	SpecsCmd.AddCommand(getSpecCmd)
 
 	getSpecCmd.Flags().StringVar(
-		&getSpecServiceFlag,
-		"service",
+		&getSpecProjectIDFlag,
+		"project",
 		"",
-		"Your Akita service.",
+		"Your Insights project ID.",
 	)
 	cobra.MarkFlagRequired(getSpecCmd.Flags(), "service")
 
@@ -117,14 +117,11 @@ func runGetSpec(specIdentifier string) error {
 
 	clientID := akid.GenerateClientID()
 
-	frontClient := rest.NewFrontClient(rest.Domain, clientID, nil)
-
-	// Convert service name to service ID.
-	serviceID, err := getServiceIDByName(frontClient, getSpecServiceFlag)
+	var serviceID akid.ServiceID
+	err := akid.ParseIDAs(getSpecProjectIDFlag, &serviceID)
 	if err != nil {
-		return err
+		return errors.Wrap(err, "failed to parse project ID")
 	}
-
 	learnClient := rest.NewLearnClient(rest.Domain, clientID, serviceID, nil)
 
 	// Check to see if the user specified an AkID or a version name.

cmd/internal/legacy/util.go

@@ -97,7 +97,7 @@ func NewRedactor(
 				)
 			}()
 			if err != nil {
-				printer.Warningf("failed to update redaction configuration for %s: %v", serviceID, err)
+				printer.Warningf("failed to update redaction configuration for %s: %v\n", serviceID, err)
 				continue
 			}
 

data_masks/redactor.go

@@ -306,7 +306,14 @@ func GetLearnSessionByTags(c rest.LearnClient, serviceID akid.ServiceID, tags ma
 
 // Get the most recent trace for a service; helper method for commands to implement the
 // --append-by-tag or --trace-tag flags.
-func GetTraceURIByTags(domain string, clientID akid.ClientID, serviceName string, tags map[tags.Key]string, flagName string) (akiuri.URI, error) {
+func GetTraceURIByTags(
+	domain string,
+	clientID akid.ClientID,
+	serviceName string,
+	serviceID akid.ServiceID,
+	tags map[tags.Key]string,
+	flagName string,
+) (akiuri.URI, error) {
 	if len(tags) == 0 {
 		return akiuri.URI{}, fmt.Errorf("Must specify a tag to match with %q", flagName)
 	}
@@ -315,14 +322,6 @@ func GetTraceURIByTags(domain string, clientID akid.ClientID, serviceName string
 		return akiuri.URI{}, fmt.Errorf("%q currently supports only a single tag", flagName)
 	}
 
-	// Resolve ServiceID
-	// TODO: find a better way to overlap this with commands that already do the lookup
-	frontClient := rest.NewFrontClient(domain, clientID, nil)
-	serviceID, err := GetServiceIDByName(frontClient, serviceName)
-	if err != nil {
-		return akiuri.URI{}, errors.Wrapf(err, "failed to resolve project name %q", serviceName)
-	}
-
 	learnClient := rest.NewLearnClient(domain, clientID, serviceID, nil)
 	learnSession, err := GetLearnSessionByTags(learnClient, serviceID, tags)
 	if err != nil {