Allow require to be shared across executions

Author: appurva21

lib/sandbox/execute-context.js

@@ -1,14 +1,6 @@
 const { isNonLegacySandbox } = require('./non-legacy-codemarkers');
 const _ = require('lodash'),
-    legacy = require('./postman-legacy-interface'),
-
-    DEPRECATED_LIBS = {
-        atob: 'global "atob" function',
-        btoa: 'global "btoa" function',
-        'crypto-js': 'global "crypto" object',
-        tv4: '"ajv" library',
-        backbone: null
-    };
+    legacy = require('./postman-legacy-interface');
 
 module.exports = function (scope, code, execution, console, timers, pmapi, onAssertion, options) {
     // if there is no code, then no point bubbling anything up
@@ -52,21 +44,36 @@ module.exports = function (scope, code, execution, console, timers, pmapi, onAss
         setImmediate: timers.setImmediate,
         clearTimeout: timers.clearTimeout,
         clearInterval: timers.clearInterval,
-        clearImmediate: timers.clearImmediate,
+        clearImmediate: timers.clearImmediate
+    });
 
-        require: (...args) => {
-            const key = args?.[0],
+    const wrappedCode = `
+        ;((originalRequire) => {
+            require = (...args) => {
+                const key = args?.[0],
+                DEPRECATED_LIBS = {
+                    atob: 'global "atob" function',
+                    btoa: 'global "btoa" function',
+                    'crypto-js': 'global "crypto" object',
+                    tv4: '"ajv" library',
+                    backbone: null
+                },
                 alt = DEPRECATED_LIBS[key];
 
-            if (alt !== undefined) {
-                console.warn(`Using "${key}" library is deprecated.${alt !== null ? ` Use ${alt} instead.` : ''}`);
-            }
+                if (alt !== undefined) {
+                    console.warn(
+                        \`Using "\${key}" library is deprecated.\${alt !== null ? \` Use \${alt} instead.\` : ''}\`
+                    );
+                }
 
-            return require(...args);
-        }
-    });
 
-    scope.exec(code, { async: true }, function (err) {
+                return originalRequire(...args);
+            }
+        })(require);
+        ${code}
+    `;
+
+    scope.exec(wrappedCode, { async: true }, function (err) {
         // we check if the execution went async by determining the timer queue length at this time
         execution.return.async = (timers.queueLength() > 0);
 

test/unit/sandbox-sanity.test.js

@@ -387,6 +387,41 @@ describe('sandbox', function () {
         });
     });
 
+    it('should  persist overridden `require` across executions', function (done) {
+        const consoleSpy = sinon.spy();
+
+        Sandbox.createContext(function (err, ctx) {
+            if (err) { return done(err); }
+
+            ctx.on('error', done);
+            ctx.on('console', consoleSpy);
+
+            ctx.execute(`
+                require = (...args) => {
+                    if (args[0] === 'utils') {
+                        return () => console.log('utils');
+                    }
+
+                    return require(...args);
+                }
+
+                require('utils')();
+            `, function (err) {
+                if (err) { return done(err); }
+
+                ctx.execute('require(\'utils\')();', function (err) {
+                    if (err) { return done(err); }
+
+                    expect(consoleSpy).to.be.calledTwice;
+                    expect(consoleSpy.firstCall.args[2]).to.equal('utils');
+                    expect(consoleSpy.secondCall.args[2]).to.equal('utils');
+
+                    done();
+                });
+            });
+        });
+    });
+
     (IS_NODE ? it : it.skip)('should have missing globals as subset of explicitly ignored globals', function (done) {
         Sandbox.createContext(function (err, ctx) {
             if (err) { return done(err); }