Move block shape check #2471
Merged
Move block shape check #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
move_block_shape_check
branch
4 times, most recently
from
a21f908 to
12f7f10
Compare
chriseth
force-pushed
the
move_block_shape_check
branch
from
12f7f10 to
0dc07f2
Compare
pacheco
reviewed
Feb 12, 2025
| /// have another one in row `i + block_size`. | ||
| fn check_block_shape(&self, code: &[Effect<T, Variable>]) -> Result<(), String> { | ||
| for (column_id, row_offsets) in written_rows_per_column(code) { | ||
| let row_offsets: BTreeSet<_> = row_offsets.into_iter().collect(); |
There was a problem hiding this comment.
isnt this already a BTreeSet?
| ) -> BTreeMap<u64, BTreeSet<i32>> { | ||
| code.iter() | ||
| .filter_map(|e| match e { | ||
| Effect::MachineCall(id, _, arguments) => match &arguments[0] { |
There was a problem hiding this comment.
does this need to handle branches?
There was a problem hiding this comment.
Ah, good point, thanks!
pacheco
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes point 2 of #2327