Implement dynamic bus (runtime witgen) #2539
Open
+154
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c959525.
georgwiese
commented
Mar 12, 2025
Comment on lines
+124
to
+125
| // As a performance optimization, already filter out sends with a static | ||
| // bus ID for which we know we don't need to track multiplicities. |
There was a problem hiding this comment.
On Keccak-via-RISC-V, this reduces multiplicity witgen from ~520ms to ~450ms (2.6% of witgen time). Before this PR, it's ~320ms. I suppose looking up the receive for each row below causes this regression. We could do more shenanigans to speed this up again in the static case, but I don't think it's worth it.
georgwiese
changed the title
georgwiese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2538
With this PR, the
dynamic_bustest passes. I did not touch JIT code yet, but it doesn't seem to be necessary in this example.