-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dynamic bus (runtime witgen) #2539
base: main
Are you sure you want to change the base?
Conversation
This reverts commit c959525.
// As a performance optimization, already filter out sends with a static | ||
// bus ID for which we know we don't need to track multiplicities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Keccak-via-RISC-V, this reduces multiplicity witgen from ~520ms to ~450ms (2.6% of witgen time). Before this PR, it's ~320ms. I suppose looking up the receive for each row below causes this regression. We could do more shenanigans to speed this up again in the static case, but I don't think it's worth it.
Builds on #2538
With this PR, the
dynamic_bus
test passes. I did not touch JIT code yet, but it doesn't seem to be necessary in this example.