Differentiate direct and indirect pens/tablets on Android #6570
Conversation
Based on the heuristic that internal `InputDevice`s are direct and external are indirect. Ideally, this would be in SDL, but I'm not sure how to pitch a cross-platform API.
| @@ -530,14 +531,40 @@ private void handleKeyboardEvent(SDL_KeyboardEvent evtKey) | |||
|
|
|||
| private void handleKeymapChangedEvent() => KeymapChanged?.Invoke(); | |||
|
|
|||
| protected abstract TabletPenDeviceType GetPenDeviceType(SDL_PenID id); | |||
There was a problem hiding this comment.
What on earth is this method? Not only is it something that looks like it should delegate straight to SDL3, not a single override of this method uses the supplied argument!
What is even the guarantee that the ID of this "pen device" is going to correlate with whatever the android implementation returns? At that point why even bother with handling the SDL "proximity events" or whatever?
At that point just commit and have this "pen device type" thing be plain global state, it's much less misleading that way.
There was a problem hiding this comment.
If this was global state, it could change when a pen is pressed down – this could lead to touch or mouse inputs getting stuck (pen pressed down as touch, but released as mouse due to global state).
|
|
||
| Debug.Assert(e != null); | ||
|
|
||
| // SDLSurface does some weird checks here for event action index, but it doesn't really matter as we only expect one pen at a time |
There was a problem hiding this comment.
This is the sort of comment that is unhelpful. What would be helpful is a link to the checks in question and an explanation of what's "weird" about it so that someone in a year or five can come in and determine what is "weird" about them.
| } | ||
|
|
||
| /// <summary> | ||
| /// Sets <see cref="LastPenDeviceType"/> iff <c>SDLGenericMotionListener_API14.onGenericMotion()</c> would call <c>onNativePen()</c>. |
There was a problem hiding this comment.
These xmldocs are also describing some super specific scenario (also referencing some sdl method at that?) without linking to any relevant source.
|
I have done more testing on this |
This PR uses the Android API 29+ (Android 10+) function
InputDevice.isExternal()to check if the tablet device is external or internal, mapping to indirect and direct respectively. The code path that propagate this value to thePenHandleris as follows:AndroidGameSurfaceevent.getDevice().isExternal()and store to a "global" variable:LastPenDeviceType(on the Android UI thread)LastPenDeviceType(on the main thread)PenHandlerTesting
Tested to work as expected on ASUS Z012D with a Gaomon S620 tablet (thanks @Danielbzac!). I would like to see testing on a Samsung Galaxy Note device to check that internal pen digitizers are actually reported as internal by this API.