pre-calculate standardised scores

Author: notbakaneko

Diff for: app/Models/Contest.php

@@ -17,6 +17,7 @@
 use Illuminate\Database\Eloquent\Relations\HasMany;
 
 /**
+ * @property-read Collection<ContestJudge> $contestJudges
  * @property \Carbon\Carbon|null $created_at
  * @property string $description_enter
  * @property string|null $description_voting
@@ -28,7 +29,7 @@
  * @property string $header_url
  * @property int $id
  * @property mixed $link_icon
- * @property-read Collection<ContestJudge> $judges
+ * @property-read Collection<User> $judges
  * @property int $max_entries
  * @property int $max_votes
  * @property string $name
@@ -57,6 +58,11 @@ class Contest extends Model
         'voting_starts_at' => 'datetime',
     ];
 
+    public function contestJudges(): HasMany
+    {
+        return $this->HasMany(ContestJudge::class);
+    }
+
     public function entries()
     {
         return $this->hasMany(ContestEntry::class);
@@ -115,6 +121,14 @@ public function assertVoteRequirement(?User $user): void
         }
     }
 
+    public function calculateScores(): void
+    {
+        $this->contestJudges->each->calculateStdDev();
+
+        $judgeVotes = ContestJudgeVote::whereHas('entry', fn ($q) => $q->whereHas('contest', fn ($qq) => $qq->where('contest_id', $this->getKey())))->get();
+        $judgeVotes->each->calculateScore();
+    }
+
     public function isBestOf(): bool
     {
         return isset($this->getExtraOptions()['best_of']);

Diff for: app/Models/ContestJudge.php

@@ -13,6 +13,8 @@
 /**
  * @property-read Contest $contest
  * @property int $contest_id
+ * @property ?float $mean
+ * @property ?float $std_dev
  * @property-read User $user
  * @property int $user_id
  */
@@ -29,7 +31,14 @@ public function user(): BelongsTo
         return $this->belongsTo(User::class, 'user_id');
     }
 
-    public function stdDev()
+    public function calculateStdDev(): void
+    {
+        [$stdDev, $mean] = $this->stdDev();
+
+        $this->update(['mean' => $mean, 'std_dev' => $stdDev]);
+    }
+
+    public function stdDev(): array
     {
         // TODO: treat missing scores as 0?
         $entryScores = ContestJudgeScore::scoresByEntry()

Diff for: app/Models/ContestJudgeVote.php

@@ -18,6 +18,7 @@
  * @property \Carbon\Carbon|null $created_at
  * @property-read ContestEntry $entry
  * @property int $id
+ * @property float $total_score_std
  * @property \Carbon\Carbon|null $updated_at
  * @property-read User $user
  * @property int $user_id
@@ -39,15 +40,17 @@ public function totalScore(): int
         return intval($this->scores()->sum('value'));
     }
 
-    public function totalScoreStd(): float
+    public function user(): BelongsTo
     {
-        [$stdDev, $mean] = ContestJudge::where(['contest_id' => $this->entry->contest_id, 'user_id' => $this->user_id])->first()->stdDev();
-
-        return ($this->totalScore() - $mean) / $stdDev;
+        return $this->belongsTo(User::class, 'user_id');
     }
 
-    public function user(): BelongsTo
+    public function calculateScore(): void
     {
-        return $this->belongsTo(User::class, 'user_id');
+        $judge = ContestJudge::where(['contest_id' => $this->entry->contest_id, 'user_id' => $this->user_id])->first();
+
+        if ($judge->std_dev !== null) {
+            $this->update(['total_score_std' => ($this->totalScore() - $judge->mean) / $judge->std_dev]);
+        }
     }
 }