use NoOverflow versions to get dates on the right side of month boundaries

Author: notbakaneko

app/Models/User.php

@@ -329,7 +329,7 @@ public function usernameChangeCost()
         $tier = max(
             $this->usernameChangeHistory()
                 ->paid()
-                ->where('timestamp', '>', Carbon::now()->subYears(3))
+                ->where('timestamp', '>', Carbon::now()->subYearsNoOverflow(3))
                 ->count(),
             $minTier,
         );

tests/Models/UserTest.php

@@ -236,7 +236,7 @@ public function testUsernameChangeCostType(string $type, int $cost)
     public function testUsernameChangeCostWindow(int $years, int $cost)
     {
         $now = CarbonImmutable::now();
-        $this->travelTo(CarbonImmutable::now()->subYears(3));
+        $this->travelTo(CarbonImmutable::now()->subYearsNoOverflow(3));
 
         $user = User::factory()->create();
         // every 6 months for 3 years = 6
@@ -251,7 +251,7 @@ public function testUsernameChangeCostWindow(int $years, int $cost)
             $this->travelTo(CarbonImmutable::now()->addMonthsNoOverflow(6));
         }
 
-        $this->travelTo($now->addYears($years));
+        $this->travelTo($now->addYearsNoOverflow($years));
         $this->assertSame($cost, $user->usernameChangeCost());
     }