Merge pull request #11153 from notbakaneko/feature/user-best-exclude-no-pp

peppy · web-flow · commit a1e27dd7182e · 2024-04-10T18:41:49.000+08:00
Exclude scores without pp from user best performance
diff --git a/app/Models/Traits/UserScoreable.php b/app/Models/Traits/UserScoreable.php
@@ -19,6 +19,7 @@ trait UserScoreable
     public function aggregatedScoresBest(string $mode, null | true $legacyOnly, int $size): array
     {
         return (new FetchDedupedScores('beatmap_id', ScoreSearchParams::fromArray([
+            'exclude_without_pp' => true,
             'is_legacy' => $legacyOnly,
             'limit' => $size,
             'ruleset_id' => Beatmap::MODES[$mode],

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ trait UserScoreable`
`19`	`19`	`public function aggregatedScoresBest(string $mode, null \| true $legacyOnly, int $size): array`
`20`	`20`	`{`
`21`	`21`	`return (new FetchDedupedScores('beatmap_id', ScoreSearchParams::fromArray([`
	`22`	`+ 'exclude_without_pp' => true,`
`22`	`23`	`'is_legacy' => $legacyOnly,`
`23`	`24`	`'limit' => $size,`
`24`	`25`	`'ruleset_id' => Beatmap::MODES[$mode],`