Merge pull request #11072 from nanaya/spotlight-checks

notbakaneko · web-flow · commit afea9a39c43e · 2024-03-07T22:24:31.000+09:00
More strict check for spotlights page
diff --git a/app/Http/Controllers/RankingController.php b/app/Http/Controllers/RankingController.php
@@ -266,11 +266,11 @@ public function kudosu()
 
     public function spotlight($mode)
     {
-        $chartId = $this->params['spotlight'] ?? null;
+        $chartId = get_int($this->params['spotlight'] ?? null);
 
         $spotlights = Spotlight::orderBy('chart_id', 'desc')->get();
         if ($chartId === null) {
-            $spotlight = $spotlights->first();
+            $spotlight = $spotlights->first() ?? abort(404);
         } else {
             $spotlight = Spotlight::findOrFail($chartId);
         }

Original file line number	Diff line number	Diff line change
`@@ -266,11 +266,11 @@ public function kudosu()`
`266`	`266`
`267`	`267`	`public function spotlight($mode)`
`268`	`268`	`{`
`269`		`- $chartId = $this->params['spotlight'] ?? null;`
	`269`	`+ $chartId = get_int($this->params['spotlight'] ?? null);`
`270`	`270`
`271`	`271`	`$spotlights = Spotlight::orderBy('chart_id', 'desc')->get();`
`272`	`272`	`if ($chartId === null) {`
`273`		`- $spotlight = $spotlights->first();`
	`273`	`+ $spotlight = $spotlights->first() ?? abort(404);`
`274`	`274`	`} else {`
`275`	`275`	`$spotlight = Spotlight::findOrFail($chartId);`
`276`	`276`	`}`