Merge pull request #11118 from bdach/preserve-failed-multi-scores

Always preserve multiplayer scores regardless of pass/fail

Author: nanaya

Diff for: app/Models/Multiplayer/ScoreLink.php

@@ -28,7 +28,8 @@ class ScoreLink extends Model
     public static function complete(ScoreToken $token, array $params): static
     {
         return \DB::transaction(function () use ($params, $token) {
-            $score = Score::createFromJsonOrExplode($params);
+            // multiplayer scores are always preserved.
+            $score = Score::createFromJsonOrExplode([...$params, 'preserve' => true]);
 
             $playlistItem = $token->playlistItem;
             $requiredMods = array_column($playlistItem->required_mods, 'acronym');

Diff for: tests/Models/Multiplayer/ScoreLinkTest.php

@@ -176,4 +176,22 @@ public function testUnexpectedModAcceptedIfAlwaysValidForSubmission()
             'user_id' => $scoreToken->user_id,
         ]);
     }
+
+    public function testFailedMultiplayerScoresArePreserved()
+    {
+        $playlistItem = PlaylistItem::factory()->create();
+        $scoreToken = ScoreToken::factory()->create([
+            'beatmap_id' => $playlistItem->beatmap_id,
+            'playlist_item_id' => $playlistItem,
+        ]);
+
+        $scoreLink = ScoreLink::complete($scoreToken, [
+            ...static::$commonScoreParams,
+            'beatmap_id' => $playlistItem->beatmap_id,
+            'ruleset_id' => $playlistItem->ruleset_id,
+            'user_id' => $scoreToken->user_id,
+            'passed' => false,
+        ]);
+        $this->assertTrue($scoreLink->score->preserve);
+    }
 }