Add user cover preset model #11081
Merged
Add user cover preset model #11081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
force-pushed
the
cover-preset-table
branch
from
be0b49c to
d9f6120
Compare
3 tasks
notbakaneko
requested changes
Apr 1, 2024
Comment on lines
+293
to
+295
| Route::post('user-cover-presets/batch-activate', 'UserCoverPresetsController@batchActivate')->name('user-cover-presets.batch-activate'); | ||
| Route::resource('user-cover-presets', 'UserCoverPresetsController', ['only' => ['index', 'store', 'update']]); | ||
|
|
There was a problem hiding this comment.
shouldn't these go under /admin?
There was a problem hiding this comment.
not if we're going to allow this to be accessible by non-admin
There was a problem hiding this comment.
would be very nice to have it under /admin now in the console page, highly doubt any other usergroup will get access to this.
(another side effect is me having to look back at this PR each time to remember the route lol)
is it the input is resizable 👀 |
notbakaneko
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the models. Not linked to user just yet (and would otherwise depend on #10804). The management page ended up weirder than expected 👀 probably can use some more javascripts/react but this basic one seems to somehow work.
No idea what group should have access to this yet so admin only for now.
Tests to be added later. Maybe.
Oh and there's bug with simple form's input which I'm not fixing here.