Fix turbo redirect #11688
Merged
Fix turbo redirect #11688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix doesn't quite work as turbo just ends up doing a browser native visit and breaks on form action due to 200 status.
nanaya
force-pushed
the
turbo-redirect-pt2
branch
from
0827c35 to
e3a1426
Compare
notbakaneko
requested changes
Nov 25, 2024
resources/js/setup-turbo.ts
Outdated
| @@ -24,6 +24,24 @@ document.addEventListener('turbo:submit-end', (e) => { | |||
| } | |||
| }); | |||
|
|
|||
| document.addEventListener('turbo:before-fetch-response', (e) => { | |||
| if (!e.detail.fetchResponse.contentType.match(/^text\/osu-turbo-redirect[ ;]*/)) { | |||
There was a problem hiding this comment.
contentType is null when replacing an existing user-cover-preset or toggling enabled/disabled (and maybe similar buttons?)
There was a problem hiding this comment.
well those only need to reload the page, not redirect
notbakaneko
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix doesn't quite work as turbo just ends up doing a browser native visit and breaks on form action due to 200 status.