Fix testUsernameChangeCostWindow setup #12062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Mar 31, 2025
| while (CarbonImmutable::now()->isBefore($now)) { | ||
| // every 6 months for 3 years = 6 | ||
| // using isBefore to setup adds too many when run at month boundaries. | ||
| for ($i = 0; $i < 6; $i++) { |
There was a problem hiding this comment.
although it's not for another three years, there's a vaguely similar problem when run on feb 29
There was a problem hiding this comment.
it ironically works fine because usernameChangeCost doesn't check if the date is in the future
There was a problem hiding this comment.
still failing with $now = CarbonImmutable::now()->subYears(1)->startOfMonth()->subDays(1);...
I guess it's more like something just doesn't use the carbon date...?
Nope, it's just $now isn't actually quite used everywhere relevant
nanaya
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a known fixed number instead of
while < $now