Use decibel scaling for volume control (version 2) #31717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #31493
Meant to work alongside ppy/osu-framework#6515
This approach works under the philosophy of implementing decibel scaling right at the slider/meter level. As a result, it makes far fewer changes to
osu-framework
, and decibel scaling is not forced on the developer the same way that it was with the first version.Here is a video showing that our decibel scaling matches PulseAudio's decibel scaling:
game.mp4
During the workflow run,
MouseWheelVolumeAdjust
tests fail. This is due to the volume's precision level not being high enough. When the precision level is increased, these tests pass:test.mp4