Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decibel scaling for volume control (version 2) #31717

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myQwil
Copy link
Contributor

@myQwil myQwil commented Jan 28, 2025

An alternative approach to #31493

Meant to work alongside ppy/osu-framework#6515

This approach works under the philosophy of implementing decibel scaling right at the slider/meter level. As a result, it makes far fewer changes to osu-framework, and decibel scaling is not forced on the developer the same way that it was with the first version.

Here is a video showing that our decibel scaling matches PulseAudio's decibel scaling:

game.mp4

During the workflow run, MouseWheelVolumeAdjust tests fail. This is due to the volume's precision level not being high enough. When the precision level is increased, these tests pass:

test.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant