Poly: Hardcode barrett multiplier #806
Merged
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most places in the code, we use magic constants with `check-magic: ...` annotations explaining their origin, rather than computing the magic constant in the code and relying on constant evaluation by the compiler. One place where this was not done is `barrett_reduce()`, where the 'magic' Barrett multiplier was computed in C. This commit aligns `barrett_reduce()` to other routines relying on magic constants, by hardcoding the magic value in C, and adding a `check-magic: ...` annotation to explain its origin. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
mkannwischer
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most places in the code, we use magic constants with
check-magic: ...annotations explaining their origin, rather than computing the magic constant in the code and relying on constant evaluation by the compiler.One place where this was not done is
barrett_reduce(), where the 'magic' Barrett multiplier was computed in C.This commit aligns
barrett_reduce()to other routines relying on magic constants, by hardcoding the magic value in C, and adding acheck-magic: ...annotation to explain its origin.