Skip to content

Commit 39be928

Browse files
fix: Changing module resolve priority (#1622)
Co-authored-by: Leah <github.leah@hrmny.sh>
1 parent 0b298ae commit 39be928

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

.changeset/eleven-olives-jump.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'preact-cli': patch
3+
---
4+
5+
Corrects module resolve priority, fixing issues with duplicated dependencies being incorrectly resolved

packages/cli/lib/lib/webpack/webpack-base-config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ module.exports = function createBaseConfig(env) {
129129
context: src,
130130

131131
resolve: {
132-
modules: [...nodeModules, 'node_modules'],
132+
modules: ['node_modules', ...nodeModules],
133133
extensions: [
134134
'.mjs',
135135
'.js',
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,7 @@
1-
const path = require('path');
2-
31
module.exports = function (config) {
4-
const loader = path.resolve(
5-
__dirname,
6-
'../../../../async-loader/async-legacy.js'
7-
);
8-
const alias = config.resolve.alias;
9-
alias['preact-cli/async-component'] = alias[
10-
'@preact/async-loader/async'
11-
] = loader;
12-
13-
for (const rule of config.module.rules) {
14-
if (/async-loader/.test(rule.loader)) {
15-
rule.loader = path.resolve(__dirname, '../../../../async-loader/legacy');
16-
}
2+
const modules = config.resolve.modules;
3+
if (modules[0] === 'node_modules') {
4+
modules.splice(0, 1);
5+
modules.push('node_modules');
176
}
187
};

0 commit comments

Comments
 (0)