fix: Changing module resolve priority #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa51866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/duplicated-dependency-import
branch
from
72db315 to
9010e2a
Compare
ForsakenHarmony
approved these changes
Nov 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Maybe covered by existing
Summary
Fixes #1616
This seems to be the correct way to fix the issue, however, it breaks the preact8 progressive hydration test as it resolves Preact through Preact-CLI's devDep on Preact v10, rather than the local (to the test) v8. #756 seems to have set this up (the behavior I'm reverting) specifically for that situation.
I've hackily reversed this change in that test using the
preact.config.js. It's quite silly but I think it's valid, as this is a situation that would only come up when preact v10 is available in a preact v8 app.This needs to wait for #1623, as the update config file will not be used until that's in