refactor: Fix source maps, error code frames, and other misc items #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely a sync from
vite-prerender-plugin
-- I'm thinking of moving that into the Preact org (as it's ~60% Preact code anyhow..) to ease maintenance a bit as this ain't great as-is. Could then make it an optional peer dep here (instead of essentially vendoring it), reducing install size for all who aren't using it. That repo has a test suite, not as good as it can be but better than here, which I'm not super excited about mirroring into this repo. Need to think about it anyhow.Changes:
resolvedConfig()
, instead, directing users toconfig()
(they might've hinted at this previously but it wasn't enforced).manualChunks
is an exception though, can only be set fromresolvedConfig()
for odd Vite-internal reasons, in case that stands out.pnpm
andyalc
both broke the "is user code" detection mechanism when parsing the stack trace for an error location as their symlinks don't really match standardnode_modules
structure. Swapped that out to a singular ID, I don't imagineheadless-prerendering
will have many false positives.