Make t and n optional arguments in store_checkpoint #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
BenjaminRodenberg
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Since I expect that this is a quite niche feature: A test would be important.
Additionally: In #59 (comment) I mention some tutorials where we could just skip t and/or n. Let's prepare a PR where we actually implement this in the tutorials. This simplifies the tutorials and also acts as an integration test for this feature.
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
…ing installation (precice#181) * Require mpi4py < 4 --------- Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
* Add note regarding the externally-managed-environment error * Provide commands that we use in tutorials. --------- Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
BenjaminRodenberg
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.