Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install FEniCS via apt-get #191

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

BenjaminRodenberg
Copy link
Member

Instead of using (and maintaining) the container benjaminrodenberg/fenics we can also use a github action to install FEniCS. As far as I understand the action automatically uses a caching mechanism to keep the time for installing packages on top of the base container at a minimum.

@BenjaminRodenberg
Copy link
Member Author

Interesting observation: The caching I mentioned above seems to cause some problem. The first time I installed FEniCS using the action everything worked. The second time (when the cache is used) it does not work anymore. I reran the tests that originally worked and they also seem to be broken now (presumably due to caching).

I will now go without the action as an alternative without caching.

@BenjaminRodenberg BenjaminRodenberg changed the title Install FEniCS via github action Install FEniCS via apt-get Jan 22, 2025
@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review January 22, 2025 11:24
@BenjaminRodenberg
Copy link
Member Author

There is no huge difference in runtime for using a docker container with pre-installed FEniCS vs. installing it in the test via apt-get. I would suggest merging this PR since it avoid the additional effort for maintaining the docker container. It also simplifies the testing since we have one less component to worry about.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a cleaner and more sustainable solution 👍

@BenjaminRodenberg BenjaminRodenberg merged commit a64f1d6 into develop Jan 22, 2025
7 checks passed
@BenjaminRodenberg BenjaminRodenberg deleted the BenjaminRodenberg-install-fenics-action branch January 22, 2025 11:50
@BenjaminRodenberg BenjaminRodenberg added this to the v2.3.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants