Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile and release workflow #228

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BenjaminRodenberg
Copy link
Member

The Dockerfile that we use for building precice/python-bindings currently breaks. The reason is a change in policy regarding installation of Python packages in recent pip versions (see here).

@MakisH We can pass --break-system-packages to install the bindings system-wide. Does this meet your requirements for the systemtests? Or would you rather follow a different approach? Are you actually using the image precice/python-bindings or are you installing via pip install git+https://github.com/precice/python-bindings.git@develop?

@MakisH
Copy link
Member

MakisH commented Feb 27, 2025

This appears now because in precice/precice#2200 we upgraded to Ubuntu 24.04, as decided in the last coding days.

The images published by this repository or by precice/precice are not used by the system tests.

Instead, we use this Dockerfile and install in a venv:

https://github.com/precice/tutorials/blob/962793d5b173d828e2309af017076d8965fcfe79/tools/tests/dockerfiles/ubuntu_2404/Dockerfile#L85-L87

However, this is not even used by our tutorials at the moment, as each Python-based tutorial initializes each own venv. See precice/tutorials#584.

The correct approach for this repository should not be the --break-system-packages, but using a virtual environment. This is what the new policy encourages.

@BenjaminRodenberg BenjaminRodenberg changed the title Update Dockerfile Remove Dockerfile and release workflow Mar 12, 2025
@BenjaminRodenberg
Copy link
Member Author

I decided to remove the Dockerfile and the release workflow. I do not think we need it anymore and should use virtual environments instead.

@BenjaminRodenberg
Copy link
Member Author

I took care of cleaning up issues related to the topic of releasing the python bindings via docker (see links above).

@fsimonis and @IshaanDesai putting you as reviewers here because of the many issues affected by this PR. I think removing the docker image in favor of pip and venv should save us a lot of maintainment work in the future. Please let me know if I'm missing something. I will merge this PR as soon as I have your approval.

Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane from my perspective.

@BenjaminRodenberg BenjaminRodenberg added this to the v3.2.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants