-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dockerfile and release workflow #228
base: develop
Are you sure you want to change the base?
Conversation
This appears now because in precice/precice#2200 we upgraded to Ubuntu 24.04, as decided in the last coding days. The images published by this repository or by Instead, we use this Dockerfile and install in a venv: However, this is not even used by our tutorials at the moment, as each Python-based tutorial initializes each own venv. See precice/tutorials#584. The correct approach for this repository should not be the |
I decided to remove the Dockerfile and the release workflow. I do not think we need it anymore and should use virtual environments instead. |
I took care of cleaning up issues related to the topic of releasing the python bindings via docker (see links above). @fsimonis and @IshaanDesai putting you as reviewers here because of the many issues affected by this PR. I think removing the docker image in favor of pip and venv should save us a lot of maintainment work in the future. Please let me know if I'm missing something. I will merge this PR as soon as I have your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane from my perspective.
The Dockerfile that we use for building
precice/python-bindings
currently breaks. The reason is a change in policy regarding installation of Python packages in recent pip versions (see here).@MakisH We can pass
--break-system-packages
to install the bindings system-wide. Does this meet your requirements for the systemtests? Or would you rather follow a different approach? Are you actually using the imageprecice/python-bindings
or are you installing viapip install git+https://github.com/precice/python-bindings.git@develop
?