Test commit

Author: pdabre12

presto-native-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java

@@ -424,7 +424,7 @@ public static QueryRunner createNativeQueryRunner(String remoteFunctionServerUds
         return createNativeQueryRunner(false, DEFAULT_STORAGE_FORMAT, Optional.ofNullable(remoteFunctionServerUds), false, false, false, false, false);
     }
 
-    public static QueryRunner createNativeQueryRunner(Map<String, String> extraProperties, String storageFormat)
+    public static QueryRunner createNativeQueryRunner(Map<String, String> extraProperties, String storageFormat, boolean isCoordinatorSidecarEnabled)
             throws Exception
     {
         int cacheMaxSize = 0;
@@ -439,7 +439,7 @@ public static QueryRunner createNativeQueryRunner(Map<String, String> extraPrope
                 storageFormat,
                 true,
                 false,
-                false,
+                isCoordinatorSidecarEnabled,
                 false,
                 false,
                 false,
@@ -452,6 +452,12 @@ public static QueryRunner createNativeQueryRunner(boolean useThrift)
         return createNativeQueryRunner(useThrift, DEFAULT_STORAGE_FORMAT);
     }
 
+    public static QueryRunner createNativeQueryRunner(boolean useThrift, boolean failOnNestedLoopJoin, boolean isCoordinatorSidecarEnabled, String storageFormat)
+            throws Exception
+    {
+        return createNativeQueryRunner(useThrift, storageFormat, Optional.empty(), failOnNestedLoopJoin, isCoordinatorSidecarEnabled, false, false, false);
+    }
+
     public static QueryRunner createNativeQueryRunner(boolean useThrift, boolean failOnNestedLoopJoin)
             throws Exception
     {

presto-native-tests/pom.xml

@@ -54,6 +54,19 @@
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.facebook.presto</groupId>
+            <artifactId>presto-native-sidecar-plugin</artifactId>
+            <scope>test</scope>
+        </dependency>
+
+        <dependency>
+            <groupId>com.facebook.presto</groupId>
+            <artifactId>presto-native-sidecar-plugin</artifactId>
+            <scope>test</scope>
+            <type>test-jar</type>
+            <version>${project.version}</version>
+        </dependency>
     </dependencies>
 
     <build>

presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestDistributedEngineOnlyQueries.java

@@ -28,18 +28,21 @@
 import java.time.format.DateTimeFormatter;
 import java.util.Objects;
 
+import static com.facebook.presto.sidecar.NativeSidecarPluginQueryRunnerUtils.setupNativeSidecarPlugin;
 import static com.google.common.base.Preconditions.checkState;
 
 public class TestDistributedEngineOnlyQueries
         extends AbstractTestEngineOnlyQueries
 {
-    private static final String timeTypeUnsupportedError = ".*Failed to parse type \\[time.*";
+    private static final String timeTypeUnsupportedError = "^Unknown type time.*";
 
     @Parameters("storageFormat")
     @Override
     protected QueryRunner createQueryRunner() throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(ImmutableMap.of(), System.getProperty("storageFormat"));
+        QueryRunner queryRunner = PrestoNativeQueryRunnerUtils.createNativeQueryRunner(false, false, true, System.getProperty("storageFormat"));
+        setupNativeSidecarPlugin(queryRunner);
+        return queryRunner;
     }
 
     @Parameters("storageFormat")

presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestOrderByQueries.java

@@ -21,14 +21,18 @@
 import org.testng.annotations.Parameters;
 import org.testng.annotations.Test;
 
+import static com.facebook.presto.sidecar.NativeSidecarPluginQueryRunnerUtils.setupNativeSidecarPlugin;
+
 public class TestOrderByQueries
         extends AbstractTestOrderByQueries
 {
     @Parameters("storageFormat")
     @Override
     protected QueryRunner createQueryRunner() throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(ImmutableMap.of(), System.getProperty("storageFormat"));
+        QueryRunner queryRunner = PrestoNativeQueryRunnerUtils.createNativeQueryRunner(false, false, true, System.getProperty("storageFormat"));
+        setupNativeSidecarPlugin(queryRunner);
+        return queryRunner;
     }
 
     @Parameters("storageFormat")

presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestRepartitionQueries.java

@@ -20,14 +20,18 @@
 import com.google.common.collect.ImmutableMap;
 import org.testng.annotations.Parameters;
 
+import static com.facebook.presto.sidecar.NativeSidecarPluginQueryRunnerUtils.setupNativeSidecarPlugin;
+
 public class TestRepartitionQueries
         extends AbstractTestRepartitionQueries
 {
     @Parameters("storageFormat")
     @Override
     protected QueryRunner createQueryRunner() throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(ImmutableMap.of(), System.getProperty("storageFormat"));
+        QueryRunner queryRunner = PrestoNativeQueryRunnerUtils.createNativeQueryRunner(false, false, true, System.getProperty("storageFormat"));
+        setupNativeSidecarPlugin(queryRunner);
+        return queryRunner;
     }
 
     @Parameters("storageFormat")

presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestRepartitionQueriesWithSmallPages.java

@@ -20,17 +20,22 @@
 import com.google.common.collect.ImmutableMap;
 import org.testng.annotations.Parameters;
 
+import static com.facebook.presto.sidecar.NativeSidecarPluginQueryRunnerUtils.setupNativeSidecarPlugin;
+
 public class TestRepartitionQueriesWithSmallPages
         extends AbstractTestRepartitionQueries
 {
     @Parameters("storageFormat")
     @Override
     protected QueryRunner createQueryRunner() throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(
+        QueryRunner queryRunner = PrestoNativeQueryRunnerUtils.createNativeQueryRunner(
                 // Use small SerializedPages to force flushing
                 ImmutableMap.of("driver.max-page-partitioning-buffer-size", "200B"),
-                System.getProperty("storageFormat"));
+                System.getProperty("storageFormat"),
+                true);
+        setupNativeSidecarPlugin(queryRunner);
+        return queryRunner;
     }
 
     @Parameters("storageFormat")

presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestWindowQueries.java

@@ -21,6 +21,8 @@
 import org.testng.annotations.Parameters;
 import org.testng.annotations.Test;
 
+import static com.facebook.presto.sidecar.NativeSidecarPluginQueryRunnerUtils.setupNativeSidecarPlugin;
+
 public class TestWindowQueries
         extends AbstractTestWindowQueries
 {
@@ -30,7 +32,9 @@ public class TestWindowQueries
     @Override
     protected QueryRunner createQueryRunner() throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(ImmutableMap.of(), System.getProperty("storageFormat"));
+        QueryRunner queryRunner = PrestoNativeQueryRunnerUtils.createNativeQueryRunner(false, false, true, System.getProperty("storageFormat"));
+        setupNativeSidecarPlugin(queryRunner);
+        return queryRunner;
     }
 
     @Parameters("storageFormat")