Always evaluate built-in functions using the presto.default namespace #25135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcmeehan
force-pushed
the
constant_old
branch
2 times, most recently
from
2ea87fe to
ca65c3a
Compare
This is needed to have consistent constant folding behavior across the codebase.
prestodb-ci
requested review from
a team,
bibith4 and
wanglinsong
and removed request for
a team
6 tasks
pdabre12
reviewed
May 21, 2025
There was a problem hiding this comment.
@tdcmeehan Thanks for the changes.
Can we add an e2e test in TestNativeSidecarPlugin to test this?
If the user has no specified a custom expression optimizer, expressions should be presumed to be in the presto.default namespace (which consists exclusively of Java functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the sidecar is used for query analysis, the default namespace is switched to reflect the different set of functions used in Velox. While eventually we wish to use Velox for both expression evaluation and also as a registry of functions, the former is taking a long time due to refactoring in Velox. In the meantime, we need function evaluation over C++ namespaces to work properly, which means we need to use the Java functions for now. This is a stopgap solution until function evaluation in Velox works end to end (tracked by #24238).
Motivation and Context
See above.
Impact
This allows constant folding to work while using Velox functions for analysis with the sidecar.
Test Plan
Tests have been added.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.