From bf4aba91ca43916fdb0d2d8ee4315d6c706f1cee Mon Sep 17 00:00:00 2001
From: Haiping Xue <xuehaiping@meta.com>
Date: Wed, 21 May 2025 01:34:35 -0700
Subject: [PATCH] misc: Remove storage parameters in velox open source code
 base (#25158)

Summary:


X-link: https://github.com/facebookincubator/velox/pull/13409

This is no longer needed as we are passing serde info with serde parameters

Reviewed By: harsharastogi, xiaoxmeng

Differential Revision: D74914260
---
 .../presto_cpp/main/connectors/PrestoToVeloxConnector.cpp   | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnector.cpp b/presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnector.cpp
index 916bf605913a3..52f33909d241e 100644
--- a/presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnector.cpp
+++ b/presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnector.cpp
@@ -1130,11 +1130,6 @@ HivePrestoToVeloxConnector::toVeloxSplit(
   for (const auto& [key, value] : hiveSplit->storage.serdeParameters) {
     serdeParameters[key] = value;
   }
-  std::unordered_map<std::string, std::string> storageParameters;
-  storageParameters.reserve(hiveSplit->storage.parameters.size());
-  for (const auto& [key, value] : hiveSplit->storage.parameters) {
-    storageParameters[key] = value;
-  }
   std::unordered_map<std::string, std::string> infoColumns = {
       {"$path", hiveSplit->fileSplit.path},
       {"$file_size", std::to_string(hiveSplit->fileSplit.fileSize)},
@@ -1158,7 +1153,6 @@ HivePrestoToVeloxConnector::toVeloxSplit(
           customSplitInfo,
           extraFileInfo,
           serdeParameters,
-          storageParameters,
           hiveSplit->splitWeight,
           splitContext->cacheable,
           infoColumns);