Skip to content

Always output left side join key for inner join #25172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

feilong-liu
Copy link
Contributor

@feilong-liu feilong-liu commented May 21, 2025

Description

Fix #25170

We have queries which originally OOM and succeeds after this change.

Motivation and Context

#25170

Impact

We have queries which originally OOM and succeeds after this change.

Test Plan

Unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Fix optimizer so that always output join key from left side for inner join

@feilong-liu feilong-liu requested a review from a team as a code owner May 21, 2025 20:30
@feilong-liu feilong-liu requested a review from jaystarshot May 21, 2025 20:30
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label May 21, 2025
@feilong-liu feilong-liu marked this pull request as draft May 21, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the LHS key values for inner join
2 participants