-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fail query runner when nodes do not come up #25184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tdcmeehan for this code.
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Show resolved
Hide resolved
3167687
to
97c0ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Mostly looks good to me, just one nit.
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
When query runners fail to launch a cluster, a log is printed that shows this, but it doesn't fail the query runner. This could result in timeouts. It is better to fail early when the cluster does not launch.
Motivation and Context
More obvious errors.
Impact
See above
Test Plan
Query runners are used throughout our testing suite, so this should be thoroughly tested with existing tests.
Contributor checklist
Release Notes