Skip to content

Always build the docs #25189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always build the docs #25189

wants to merge 1 commit into from

Conversation

tdcmeehan
Copy link
Contributor

Description

There was a build failure on trunk because the docs failed to build. Docs only build currently if there's a change detected in the docs directory. However, there are some subtle interactions between the docs and the libraries and code that we use, so it's safest to always build the docs.

Motivation and Context

There was a build failure on trunk reported due to this issue (#25177).

Impact

Docs are relatively quick to build, so it should be safe to always build them.

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

There was a build failure on trunk because the docs failed to build.  Docs only build currently if there's a change detected in the docs directory.  However, there are some subtle interactions between the docs and the libraries and code that we use, so it's safest to always build the docs to prevent issues such as #25177.
@tdcmeehan tdcmeehan requested review from czentgr and a team as code owners May 23, 2025 20:08
@tdcmeehan tdcmeehan requested a review from jaystarshot May 23, 2025 20:08
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label May 23, 2025
@prestodb-ci prestodb-ci requested review from a team and ScrapCodes and removed request for a team May 23, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants