Migrate to SQLDelight #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PretixScan.data is no longer needed. This change removes the setup of the BlockingEntityStore instance and moves the SQLCipher migration logic to the init code for the SQLDelight database.
The Android driver already handles migrations and schema creation for us.
To avoid trouble with migrations, it's safer to just re-open the DB after the cipher migration, so that SQLDelight's on-open hooks can run properly. In the previous state, at least some of the initial queries failed, including at least one `PRAGMA user_version;` query.
Questions are not synced when running against a pretixSCAN proxy.
optString returns "null" for null values, which makes "null" visible in the UI.
antweb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.