Avoid triggering click event on key down, and set focus on search input after submit #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and set focus on search input after submit)
seirasto
reviewed
Mar 16, 2023
| dispatch | ||
| ); | ||
|
|
||
| searchRef.current.focus(); |
There was a problem hiding this comment.
Can you add a comment here (and in the similar locations in the other files) regarding functionality e.g. "Switch focus to question text field"
There was a problem hiding this comment.
Sure. Comments added.
seirasto
reviewed
Mar 17, 2023
| # needed for write access for deployment.sh | ||
| RUN mkdir /tmp/proxy_temp && chmod 0757 /usr/share/nginx/html/ | ||
|
|
There was a problem hiding this comment.
what is this code below for?
There was a problem hiding this comment.
There's a mismatch between the feature branch's base and the PR base. These changes are from acl2023_demo.
|
Closed due to base branch mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of triggering the request on any key down, implementing form submit behavior. Additionally, sets the focus on the search input after submitting. Implemented in Retrieval, Reading and QA.