Merged in r2-2807-fix-default-maximum_attachments_per_record (pull request #6747)

R2-2807 Fix default maximum_attachments_per_record

Author: aespinoza-quoin

app/models/system_settings.rb

@@ -8,6 +8,7 @@
 # SystemSetting should be invoked using the singleton SystemSettings#current method.
 # Any update to the data will only take effect after the system is rebooted
 # and the singleton is reloaded.
+# rubocop:disable Metrics/ClassLength
 class SystemSettings < ApplicationRecord
   include LocalizableJsonProperty
   include ConfigurationRecord
@@ -144,6 +145,10 @@ def maximum_users_fields_present?
       maximum_users.is_a?(Integer) && maximum_users_warning.is_a?(Integer)
   end
 
+  def maximum_attachments_per_record
+    super || Attachment::DEFAULT_MAX_ATTACHMENTS
+  end
+
   class << self
     def current(rebuild = false)
       return @current unless @current.nil? || rebuild
@@ -174,3 +179,4 @@ def primary_age_ranges
     end
   end
 end
+# rubocop:enable Metrics/ClassLength

app/views/api/v2/system_settings/index.json.jbuilder

@@ -15,6 +15,9 @@ json.data do
   json.reporting_location_config current_user.role.reporting_location_config
   json.approvals_labels FieldI18nService.to_localized_values(@system_setting.approvals_labels_i18n)
   json.export_require_password ZipService.require_password?
+  json.system_options @system_setting.system_options
+                                     .merge('maximum_attachments_per_record' =>
+                                            @system_setting.maximum_attachments_per_record)
   if code_of_conduct
     json.code_of_conduct do
       json.partial! 'api/v2/codes_of_conduct/code_of_conduct', code_of_conduct:

spec/models/system_settings_spec.rb

@@ -73,5 +73,11 @@
         expect(@system_settings).to be_valid
       end
     end
+
+    context '#maximum_attachments_per_record' do
+      it 'when is not defined return default value' do
+        expect(@system_settings.maximum_attachments_per_record).to eq(Attachment::DEFAULT_MAX_ATTACHMENTS)
+      end
+    end
   end
 end

spec/requests/api/v2/system_settings_controller_spec.rb

@@ -68,8 +68,7 @@
         case_plan: 'Case Plan',
         closure: 'Closure'
       },
-      maximum_users: 55,
-      maximum_attachments_per_record: 23
+      maximum_users: 55
     )
   end
 
@@ -88,7 +87,7 @@
       expect(json['data']['system_options']['maximum_users']).to eq(@system_settings.maximum_users)
       expect(
         json['data']['system_options']['maximum_attachments_per_record']
-        ).to eq(@system_settings.maximum_attachments_per_record)
+      ).to eq(@system_settings.maximum_attachments_per_record)
     end
 
     it 'lists system_settings and all agencies and all modules when the param *extended* is true on the request' do