Merged in r2-3211-fix-disabled-fields (pull request #7078)

R2-3211 - Fix: Disable fields only when they have a subform_summary

Approved-by: Joshua Toliver

Author: dhernandez-quoin

app/javascript/components/record-form/components/render-form-sections.js

@@ -31,7 +31,7 @@ const renderFormFields = (
   return form.fields.map(field => {
     const tags = getOptionStringsTags(field, values);
     const fieldProps = {
-      field: field.set("disabled", !isNil(field.subform_summary)),
+      field: !isNil(field.subform_summary) ? field.set("disabled", true) : field,
       form,
       mode,
       recordType,

app/javascript/components/record-form/components/render-form-sections.spec.js

@@ -78,7 +78,7 @@ describe("renderFormSections()", () => {
   it("renders summary fields disabled", () => {
     const externalForms = () => {};
     const selectedForm = "form1";
-    const userPermittedFormsIds = fromJS({ selectedForm: "rw" });
+    const userPermittedFormsIds = fromJS({ form1: "rw" });
     const mobileDisplay = false;
     const handleToggleNav = () => {};
     const i18n = () => {};
@@ -139,4 +139,69 @@ describe("renderFormSections()", () => {
     expect(screen.getAllByRole("textbox")).toHaveLength(2);
     expect(screen.getAllByRole("textbox")[1]).toHaveClass("Mui-disabled");
   });
+
+  it("renders fields disabled when disabled is true", () => {
+    const externalForms = () => {};
+    const selectedForm = "form1";
+    const userPermittedFormsIds = fromJS({ form1: "rw" });
+    const mobileDisplay = false;
+    const handleToggleNav = () => {};
+    const i18n = () => {};
+    const recordType = "recordType1";
+    const attachmentForms = [];
+    const mode = { isEdit: true };
+    const record = fromJS({});
+    const primeroModule = "primeroModule1";
+
+    const formSectionsRender = renderFormSections(
+      externalForms,
+      selectedForm,
+      userPermittedFormsIds,
+      mobileDisplay,
+      handleToggleNav,
+      i18n,
+      recordType,
+      attachmentForms,
+      mode,
+      record,
+      primeroModule
+    );
+
+    const formSection = () =>
+      formSectionsRender(
+        [
+          FormSectionRecord({
+            unique_id: "form1",
+            visible: true,
+            fields: [
+              FieldRecord({
+                name: "field1",
+                type: TEXT_FIELD,
+                visible: true,
+                disabled: true
+              }),
+              FieldRecord({
+                name: "field2",
+                type: TEXT_FIELD,
+                visible: true
+              })
+            ]
+          })
+        ],
+        () => {},
+        () => {},
+        { sex: "male", age: 19 },
+        false
+      );
+
+    // eslint-disable-next-line react/display-name
+    function RenderedFormSections() {
+      return <>{formSection()}</>;
+    }
+
+    mountedComponent(<RenderedFormSections />, {}, {}, [], { initialValues: {} });
+
+    expect(screen.getAllByRole("textbox")).toHaveLength(2);
+    expect(screen.getAllByRole("textbox")[0]).toHaveClass("Mui-disabled");
+  });
 });