Resolved PR comments

Author: Srinivas9933

app/javascript/components/record-list/add-record-menu.spec.js

@@ -1,6 +1,6 @@
 import { fromJS } from "immutable";
 
-import { mountedComponent, screen } from "../../test-utils";
+import { mountedComponent, screen, userEvent } from "../../test-utils";
 import { RECORD_PATH } from "../../config";
 import { PrimeroModuleRecord } from "../application/records";
 
@@ -38,40 +38,42 @@ describe("<AddRecordMenu /> record-list/add-record-menu", () => {
   });
 
   it("renders a single <Button /> because user only has access to a single module", () => {
-    mountedComponent(<AddRecordMenu {...props} /> , state);
+    mountedComponent(<AddRecordMenu {...props} />, state);
 
-    expect(screen.getAllByRole('button')).toHaveLength(1)
+    expect(screen.getAllByRole("button")).toHaveLength(1);
   });
 
   it("renders a single <Menu /> because user has access more than one module", () => {
-  
-    mountedComponent(<AddRecordMenu {...props} /> , state.merge(fromJS({ user: { modules: ["primerotest-1", "primerotest-3"] } })));
+    mountedComponent(
+      <AddRecordMenu {...props} />,
+      state.merge(fromJS({ user: { modules: ["primerotest-1", "primerotest-3"] } }))
+    );
 
-    expect(screen.getByTestId('menu')).toBeInTheDocument()
-  
+    expect(screen.getByTestId("menu")).toBeInTheDocument();
   });
 
-  it("opens a <CreateRecordDialog /> if module allow_searchable_ids", () => {
+  it("opens a <CreateRecordDialog /> if module allow_searchable_ids", async () => {
+    const user = userEvent.setup();
 
-
-    mountedComponent(<AddRecordMenu {...props} /> , state.merge(fromJS({ user: { modules: ["primerotest-3"] } })));
-
-    expect(screen.getAllByRole('button')).toHaveLength(1)
+    mountedComponent(
+      <AddRecordMenu {...{ ...props }} />,
+      state.merge(fromJS({ user: { modules: ["primerotest-3"] } }))
+    );
+    await user.click(screen.getByTestId("new-record"));
+    expect(screen.getAllByRole("presentation")).toHaveLength(1);
   });
 
   it("does not render <CreateRecordDialog /> if module does not allow_searchable_ids", () => {
- 
-
-    mountedComponent(<AddRecordMenu {...props} /> , state.merge(fromJS({ user: { modules: ["primerotest-1"] } })));
-
-    expect(screen.queryByTestId('CreateRecordDialog')).toBeNull()
-
+    mountedComponent(<AddRecordMenu {...props} />, state.merge(fromJS({ user: { modules: ["primerotest-1"] } })));
+    expect(screen.queryByTestId("CreateRecordDialog")).toBeNull();
   });
 
   it("does not render <CreateRecordDialog /> if recordType is not cases", () => {
+    mountedComponent(
+      <AddRecordMenu {...{ recordType: RECORD_PATH.tracing_requests }} />,
+      state.merge(fromJS({ user: { modules: ["primerotest-1"] } }))
+    );
 
-    mountedComponent(<AddRecordMenu { ...{recordType: RECORD_PATH.tracing_requests} } /> , state.merge(fromJS({ user: { modules: ["primerotest-1"] } })));
-
-    expect(screen.queryByTestId('CreateRecordDialog')).toBeNull()
+    expect(screen.queryByTestId("CreateRecordDialog")).toBeNull();
   });
 });

app/javascript/components/record-list/container.spec.js

@@ -1,6 +1,3 @@
-// Copyright (c) 2014 - 2023 UNICEF. All rights reserved.
-
-import { Route } from "react-router-dom";
 import { fromJS, OrderedMap } from "immutable";
 
 import { ACTIONS } from "../permissions";
@@ -11,7 +8,6 @@ import { PrimeroModuleRecord } from "../application/records";
 import RecordList from "./container";
 
 describe("<RecordList />", () => {
-
   const initialState = fromJS({
     records: {
       FiltersTabs: {
@@ -305,41 +301,39 @@ describe("<RecordList />", () => {
   });
 
   it("renders record list table", done => {
-    mountedComponent(<RecordList />,initialState, ["/cases"])
-    expect(screen.getByRole('toolbar')).toBeInTheDocument()
+    mountedComponent(<RecordList />, initialState, ["/cases"]);
+    expect(screen.getByRole("toolbar")).toBeInTheDocument();
     done();
   });
 
   it("renders record view modal", done => {
-    mountedComponent(<RecordList />,initialState, ["/cases"])
-    expect(screen.getAllByText('messages.record_list.rows_per_page')).toHaveLength(2)
-   
+    mountedComponent(<RecordList />, initialState, ["/cases"]);
+    expect(screen.getAllByText("messages.record_list.rows_per_page")).toHaveLength(2);
+
     done();
   });
 
   it("opens the view modal when a record is clicked", () => {
-    mountedComponent(<RecordList />,initialState, ["/cases"])
-    expect(screen.getAllByText('messages.record_list.rows_per_page')).toHaveLength(2)
+    mountedComponent(<RecordList />, initialState, ["/cases"]);
+    expect(screen.getAllByText("messages.record_list.rows_per_page")).toHaveLength(2);
   });
 
   it("renders filters", () => {
-    mountedComponent(<RecordList />,initialState, ["/cases"])
-    expect(screen.getByTestId('filters')).toBeInTheDocument()
-   
+    mountedComponent(<RecordList />, initialState, ["/cases"]);
+    expect(screen.getByTestId("filters")).toBeInTheDocument();
   });
 
   describe("when offline", () => {
-
     it("when a record is clicked it does not open the view modal", () => {
-        mountedComponent(<RecordList />,initialState.setIn(["application", "online"], false), ["/cases"])
-        expect(screen.getByTestId('filters')).toBeInTheDocument()
+      mountedComponent(<RecordList />, initialState.setIn(["application", "online"], false), ["/cases"]);
+      expect(screen.queryAllByRole("presentation")).toHaveLength(0);
     });
   });
 
   describe("when age is 0", () => {
     it("renders a 0 in the cell ", () => {
-        mountedComponent(<RecordList />,initialState.setIn(["application", "online"], false), ["/cases"])
-        expect(screen.getAllByText('0-0 messages.record_list.of 0')).toHaveLength(2)
+      mountedComponent(<RecordList />, initialState.setIn(["application", "online"], false), ["/cases"]);
+      expect(screen.getAllByText("0-0 messages.record_list.of 0")).toHaveLength(2);
     });
   });
 });

package.json

@@ -23,9 +23,7 @@
     "test:coverage": "NODE_ENV=test nyc --nycrc-path './.nycrc.yml' npm run test:all",
     "test:run": "NODE_ENV=test mocha --timeout 8000  --check-leaks --parallel --reporter=dot --exit",
     "test:all-bb": "NODE_ENV=test mocha --timeout 8000 --check-leaks --reporter=dot './app/javascript/**/*.unit.test.js'",
-    "test:new": "NODE_ENV=test NODE_OPTIONS='--max-old-space-size=6144' jest --no-compilation-cache --clearMocks --forceExit",
-    "test:new:profile": "NODE_ENV=test NODE_OPTIONS='--max-old-space-size=6144' node --no-compilation-cache --expose-gc ./node_modules/.bin/jest --runInBand --logHeapUsage --detectOpenHandles",
-    "test:new:debug": "npm run test:new:profile -- --inspect-brk",
+    "test:new": "NODE_ENV=test jest",
     "jscpd": "npm run jscpd:run 'app/javascript/**'",
     "jscpd:run": "jscpd",
     "lint": "npm run lint:run -- --fix",