[New] Added test cases for pages export list #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoliver-quoin
force-pushed
the
develop_react_upgrade
branch
2 times, most recently
from
0211087 to
a407855
Compare
dhernandez-quoin
requested changes
Feb 20, 2024
| }); | ||
|
|
||
| it("should render <PageContent>", () => { | ||
| expect(component.find(PageContent)).to.have.lengthOf(1); | ||
| mountedComponent(<ExportList />, {}, initialState); | ||
| expect(screen.getByText(/messages.record_list.rows_per_page/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
The PageContent component is not related to pagination. I think you will need a test-id.
There was a problem hiding this comment.
Why was this test removed?
Srinivas9933
force-pushed
the
trigyn-testcases-pages-export-list
branch
from
348dfcf to
46dd49e
Compare
|
|
||
| it("should render <IndexTable>", () => { | ||
| mountedComponent(<ExportList />, {}, initialState); | ||
| expect(screen.getByText(/messages.record_list.rows_per_page/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
Need something else to key off of like role table or something
jtoliver-quoin
merged commit e393fff
into
primeroIMS:develop_react_upgrade
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for pages export list component.