[New] Added test cases for pages admin users form #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoliver-quoin
force-pushed
the
develop_react_upgrade
branch
2 times, most recently
from
0211087 to
a407855
Compare
dhernandez-quoin
requested changes
Feb 12, 2024
app/javascript/components/pages/admin/users-form/container.spec.js
Outdated
Show resolved
Hide resolved
|
|
||
| it("renders 14 fields", () => { | ||
| mountedComponent(<UsersForm mode="new" />, initialState, ["/admin/users"]) | ||
| expect(screen.getAllByRole('textbox')).toHaveLength(14) |
There was a problem hiding this comment.
Why did this change to 14?
There was a problem hiding this comment.
Based on test mock state, we are rendering 14 text fields in the DOM.
dhernandez-quoin
requested changes
Mar 22, 2024
| expect(screen.getByText('buttons.save')).toBeInTheDocument() | ||
| }); | ||
|
|
||
| it("check the textbox fields length", () => { |
There was a problem hiding this comment.
Before, this test checked that 19 fields were rendered. I think you will need to check that the other 5 fields were rendered.
There was a problem hiding this comment.
They were only 14 textbox fields rendered in the DOM
Srinivas9933
force-pushed
the
trigyn-testcases-pages-admin-users-form
branch
2 times, most recently
from
c3eb033 to
eb17c74
Compare
Srinivas9933
force-pushed
the
trigyn-testcases-pages-admin-users-form
branch
from
eb17c74 to
e67baa6
Compare
dhernandez-quoin
merged commit 51193db
into
primeroIMS:develop_react_upgrade
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for pages admin users form component.