[New] Added test cases for pages admin form builder components transl… #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez-quoin
requested changes
Nov 1, 2023
|
|
||
| expect(fields).to.deep.equal(expectedNames); | ||
| mountedFormComponent(<FieldTranslationRow {...props} />, state) | ||
| expect(screen.getAllByRole('textbox')).toHaveLength(1); |
There was a problem hiding this comment.
At least 2 inputs should exist in a FieldTranslationRow one for the English language and one for the selected language.
jtoliver-quoin
force-pushed
the
develop_react_upgrade
branch
2 times, most recently
from
0211087 to
a407855
Compare
dhernandez-quoin
changed the base branch from
develop_react_upgrade
to
develop_msal_v2
dhernandez-quoin
changed the base branch from
develop_msal_v2
to
develop_react_upgrade
| expect(component.find(FieldTranslationRow)).to.have.lengthOf(1); | ||
| localesToRender.mockReturnValue([fromJS({ id: "en" })]); | ||
| mountedFormComponent(<FieldTranslationRow {...props} />, state); | ||
| expect(screen.getByText("forms.manage")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("should render the <FormSectionField /> for the available languages", () => { |
There was a problem hiding this comment.
This test should test if there is a form section field for en, ar, and fr locales. There should be 3 inputs with different name attributes
"fields.field_1.display_name.en",
"fields.field_1.display_name.fr",
"fields.field_1.display_name.ar"
There was a problem hiding this comment.
Looks like the return of localesToRender is returning an plain array. You can remove the fromJS
| state | ||
| })); | ||
| }); | ||
| const props = { field: fromJS(field1), selectedLocaleId: "en" }; | ||
|
|
||
| it("should render <FieldTranslationRow />", () => { |
There was a problem hiding this comment.
Remove this unit test
jtoliver-quoin
requested changes
Apr 5, 2024
| expect(component.find(FieldTranslationRow)).to.have.lengthOf(1); | ||
| localesToRender.mockReturnValue([fromJS({ id: "en" })]); | ||
| mountedFormComponent(<FieldTranslationRow {...props} />, state); | ||
| expect(screen.getByText("forms.manage")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("should render the <FormSectionField /> for the available languages", () => { |
There was a problem hiding this comment.
Looks like the return of localesToRender is returning an plain array. You can remove the fromJS
…ations form components field translation
Srinivas9933
force-pushed
the
trigyn-testcases-pages-admin-form-builder-components-translations-form-components-field-translation-row
branch
from
76a171c to
759a1c1
Compare
…n-form-builder-components-translations-form-components-field-translation-row
|
Already merged here: #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for pages admin form builder components translations form components field translation component.