Skip to content

Allow string concatenation with the the Option's symbol #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexangelj opened this issue Jan 21, 2021 · 0 comments
Open

Allow string concatenation with the the Option's symbol #145

Alexangelj opened this issue Jan 21, 2021 · 0 comments

Comments

@Alexangelj
Copy link
Contributor

Each ERC-20 option has the same symbol: "PRM". These can be improved by adding prefixes which represent the option and the underlying assets.

For example, Long options could be prefixed with "l" and short options prefixed with "s". Then, WETH long options would have the symbol "LWETH". Maybe, include put/calls as well?

Right now, calls are implied if the option has a baseValue of 1. Puts are implied by having a quoteValue of 1. Maybe make this clearer in the option symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant