Skip to content

Commit

Permalink
feat: add newer php versions (#63)
Browse files Browse the repository at this point in the history
* feat: add newer php versions

* fix: bump actions/cache@v3

* fix: switch to latest ubuntu

* chore: fix

* fix: remove php 8.4

* fix: test deprecation warning
  • Loading branch information
krzaczek authored Jan 17, 2025
1 parent 7583ee6 commit 09666dc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
operating-system: [ubuntu-20.04]
php-versions: ['7.4', '8.0', '8.1', '8.2']
php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3']

steps:
- name: Set default PHP version ${{ matrix.php-versions }}
Expand All @@ -29,7 +29,7 @@ jobs:

- name: Cache Composer packages
id: composer-cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: vendor
key: ${{ runner.os }}-php${{ matrix.php-versions }}-${{ hashFiles('**/composer.lock') }}
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Install dependencies
if: steps.composer-cache.outputs.cache-hit != 'true'
run: composer install --prefer-dist --no-progress --no-suggest
run: composer install --prefer-dist --no-progress

- name: Prepare for Quality
run: /bin/sh -c 'mkdir -p ${{ github.workspace }}/build/logs && touch ${{ github.workspace }}/build/logs/checkstyle.xml'
Expand All @@ -47,7 +47,7 @@ jobs:
run: php -dxdebug.mode=coverage ${{ github.workspace }}/vendor/bin/phpunit

- name: Publish code coverage
if: ${{ matrix.php-versions == '8.1' }}
if: ${{ matrix.php-versions == '8.3' }}
uses: paambaati/codeclimate-action@v3.0.0
env:
CC_TEST_REPORTER_ID: aa35d8bb9e77ff095a71b1b8c71888fcb4ae153d3a0c29f1e637a8af514feb7e
Expand Down
2 changes: 1 addition & 1 deletion tests/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function testClientObjectResponse()
]);

$this->assertIsObject($response);
$this->assertObjectHasAttribute('foo', $response);
$this->assertTrue(property_exists($response, 'foo'));
}

public function testBasicClientNoAppKey()
Expand Down

0 comments on commit 09666dc

Please sign in to comment.