added hour-restrictions for updater and improved frontendlanguage-handling in updater

Author: StiftungAusNachlass

l10n/custom-data-type-gnd.csv

@@ -67,8 +67,12 @@ custom.data.type.gnd.config.parameter.schema.add_subjects.value.checkbox,Sachbeg
 custom.data.type.gnd.config.parameter.schema.add_works.value.checkbox,Werke,Works
 custom.data.type.gnd.config.parameter.schema.add_conferenceorevent.value.checkbox,Konferenzen und Veranstaltungen,Conference and events
 custom.data.type.gnd.url.tooltip,zu **%(name)s** bei der Deutschen Nationalbibliothek springen,jump to **%(name)s** at German National Library (DNB)
-server.config.name.system.update_interval_gnd,GND-Update-Einstellungen,GND-Update-Settings
-server.config.parameter.system.update_interval_gnd.days.label,Tage zwischen Updates,Days between updates
+server.config.name.system.update_gnd,GND-Update-Einstellungen,GND-Update-Settings
+server.config.parameter.system.update_gnd.restrict_time.label,Beschränke Updates auf bestimmte Stunden?,Restrict updates to specific hours?
+server.config.parameter.system.update_gnd.restrict_time.checkbox,Ja - beschränken,Yes - restrict
+server.config.parameter.system.update_gnd.from_time.label,Stunde von (Zahl 0-24),Hour from (Int 0-24)
+server.config.parameter.system.update_gnd.to_time.label,Stunde bis (Zahl 0-24),Hour to (Int 0-24)
+server.config.parameter.system.update_gnd.default_language.label,Standard-Datensprache als Fallback für Update (ISO 639-1),Default-data-language (as fallback) for update (ISO 639-1)
 custom.data.type.gnd.config.parameter.mask.editor_display.value.label,Editor-Ansicht,Editor-Display
 custom.data.type.gnd.config.option.mask.editor_display.value.default,Standard,Default
 custom.data.type.gnd.config.option.mask.editor_display.value.condensed,1 Zeile,One-liner

manifest.master.yml

@@ -90,20 +90,29 @@ custom_types:
                 value: "%info.json%"
       timeout: 60
       batch_size: 1
-      expires_days: 1
-      interval_base_config: update_interval_gnd.days
-              
+      expires_days: 1              
 
 base_config:
-  - name: update_interval_gnd
+  - name: update_gnd
     group: update_custom_data_type
     parameters:
-      days:
+      restrict_time:
+        type: bool
+        default: false
+        position: 0
+      from_time:
         type: int
+        default: 19
         min: 0
-        default: 0
-        position: 0
+        max: 24
+        position: 1
+      to_time:
+        type: int
+        default: 4
+        min: 0
+        max: 24
+        position: 2
       default_language:
         type: text
         default: 'de'
-        position: 1
+        position: 3

src/updater/gndUpdater.js

@@ -150,6 +150,11 @@ main = (payload) => {
                             newCdata.conceptURI = data.id;
                             newCdata.conceptName = data.preferredName;
 
+                            // if no frontendLanguage exists in originalData: add
+                            if (! originalCdata?.frontendLanguage?.length == 2) {
+                                originalCdata.frontendLanguage = defaultLanguage;
+                            }
+                            // save frontend language (same as given or default)
                             newCdata.frontendLanguage = originalCdata.frontendLanguage;
 
                             newCdata.facetTerm = GNDUtil.getFacetTerm(newCdata, databaseLanguages);
@@ -219,6 +224,29 @@ outputErr = (err2) => {
 
     process.stdin.setEncoding('utf8');
 
+    ////////////////////////////////////////////////////////////////////////////
+    // check if hour-restriction is set
+    ////////////////////////////////////////////////////////////////////////////
+
+    if(info?.config?.plugin?.['custom-data-type-gnd']?.config?.update_gnd?.restrict_time === true) {
+        let plugin_config = info.config.plugin['custom-data-type-gnd'].config.update_gnd;
+        // check if hours are configured
+        if(plugin_config?.from_time !== false && plugin_config?.to_time !== false) {
+            const now = new Date();            
+            const hour = now.getHours();
+            // check if hours do not match
+            if(hour < plugin_config.from_time && hour >= plugin_config.to_time) {
+                // exit if hours do not match
+                outputData({
+                    "state": {
+                        "theend": 2,
+                        "log": ["hours do not match, cancel update"]
+                    }
+                });
+            }
+        }
+    }
+
     access_token = info && info.plugin_user_access_token;
 
     if (access_token) {
@@ -235,7 +263,7 @@ outputErr = (err2) => {
 
             frontendLanguages = config.system.config.languages.frontend;
 
-            const testDefaultLanguageConfig = config.plugin['custom-data-type-gnd'].config.update_interval_gnd.default_language;
+            const testDefaultLanguageConfig = config.plugin['custom-data-type-gnd'].config.update_gnd.default_language;
             if (testDefaultLanguageConfig) {
                 if (testDefaultLanguageConfig.length == 2) {
                     defaultLanguage = testDefaultLanguageConfig;