-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test cmake_gcc_arm #401
Conversation
@@ -64,7 +64,7 @@ set(SOURCES_S ${SOURCES_S} "{{file}}"){% endfor %} | |||
{% for file in source_files_obj %} | |||
set(OBJECT_FILES ${OBJECT_FILES} "{{file}}"){% endfor %} | |||
|
|||
set(COMMON_FLAGS "-mcpu={{core}} {% for flag in misc['common_flags'] %} {{flag}}{% endfor %}") | |||
set(COMMON_FLAGS "-mcpu={{core}} -mthumb {% for flag in misc['common_flags'] %} {{flag}}{% endfor %}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be in the common flags ? I would assume arm mode is possible, not only thumb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm matching the makefile template for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok we can fix that later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#402 opened to address that issue in the future.
c901ae7
to
aa27fcd
Compare
resolves #347
aa27fcd
to
6cf5028
Compare
Uh, so it succeeded on pypi, which I was not expecting. I'm going to see if I can force the compiler to be what I want. |
245df90
to
2d77367
Compare
2d77367
to
45a14fa
Compare
I know this is a bit unorthodox, but after removing arm-none-eabi-gcc from my machine, all tests pass. I don't know how the CI is getting past line 31 of the CMakeList.txt |
Strange, only one test group failes, travis says pypi , and it's because of build does not return -1, so it does not fail. reports no errors :/ any indications? |
Yeah, the pypi script finds gcc, when it should fail to find arm-none-eabi-gcc. |
What's the status of this PR, tests are still red |
I can't seem to force cmake with pypi on travis to bail when it does not find the right compiler. I can't reproduce the problem. |
I fetched this locally, run test_build test ,got 2 errors:
|
That's not expected. You should be getting 3 failures.
versions:
|
Our versions of cmake are very different. |
I don't have time to update this PR, so I'm going to close it. If you would like to start where I left off, you are welcome to use the cmake-bulid branch. |
resolves #347